-
Notifications
You must be signed in to change notification settings - Fork 10
[SAC-27535] [tap-frontapp] - fix extraction failures #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SAC-27535] [tap-frontapp] - fix extraction failures #28
Conversation
976e331
to
9f6165a
Compare
5b4cdab
to
065489b
Compare
#def check_authorization(atx): | ||
# atx.client.get('/settings') | ||
|
||
|
||
# Some taps do discovery dynamically where the catalog is read in from a | ||
# call to the api but with the odd frontapp structure, we won't do that | ||
# here we never use atx in here since the schema is from file but we | ||
# would use it if we pulled schema from the API def discover(atx): | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason this is removed?!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is removed because this block was originally part of the older inlines discover() in init.py.
Since the discovery logic has now been moved to discover.py, the comments has been cleaned up.
tap_frontapp/__init__.py
Outdated
import os | ||
import sys | ||
import json | ||
|
||
import singer | ||
from singer import utils | ||
from singer.catalog import Catalog, CatalogEntry, Schema | ||
from singer.catalog import Catalog | ||
from . import streams |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This import from . import streams
is not getting used anywhere in the file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed it
tap_frontapp/sync.py
Outdated
@@ -0,0 +1,38 @@ | |||
"""Module for syncing selected FrontApp streams using Singer framework.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need of file level docstrings. Can you please remove wherever added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed it
Removed type annotations from the file as per review
Removed type annotations from file as per review
Removed type annotations as per review
Removed type annotations as per comment
Removed unnecessary header as per review
Removed header comment
Removed file level docstring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kindly review
#def check_authorization(atx): | ||
# atx.client.get('/settings') | ||
|
||
|
||
# Some taps do discovery dynamically where the catalog is read in from a | ||
# call to the api but with the odd frontapp structure, we won't do that | ||
# here we never use atx in here since the schema is from file but we | ||
# would use it if we pulled schema from the API def discover(atx): | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is removed because this block was originally part of the older inlines discover() in init.py.
Since the discovery logic has now been moved to discover.py, the comments has been cleaned up.
Add EOF
62f087f
into
feature/SAC-27536-frontapp-libraries
Description of change
Enhanced http.py to handle rate-limiting using back off strategy.
Added support for X-Ratelimit-Remaining and X-Ratelimit-Reset headers.
Manual QA steps
Ran unit tests:
test_client.py
Circle CI passes.
Risks
Any dependency might affect singer execution.
Rollback steps
AI generated code
https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code