-
Notifications
You must be signed in to change notification settings - Fork 10
Feature/sac 27535 frontapp #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
tap_frontapp/__init__.py
Outdated
refs = {} | ||
for sub_stream_id in dependencies: | ||
refs[sub_stream_id] = load_schema(sub_stream_id) | ||
refs = {sub_id: load_schema(sub_id) for sub_id in dependencies} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a blocking change
refs = {sub_id: load_schema(sub_id) for sub_id in dependencies} | |
refs = {sub_stream_id: load_schema(sub_stream_id) for sub_stream_id in dependencies} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed it
tap_frontapp/sync.py
Outdated
LOGGER.info("Selected streams: %s", streams_to_sync) | ||
|
||
last_stream = singer.get_currently_syncing(state) | ||
LOGGER.info("Last stream synced (if resuming): %s", last_stream) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOGGER.info("Last stream synced (if resuming): %s", last_stream) | |
LOGGER.info("Currently syncing: %s", last_stream) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed it
tap_frontapp/discover.py
Outdated
LOGGER = singer.get_logger() | ||
|
||
|
||
def discover() -> Catalog: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To keep consistency with existing implementation, please remove type annotation
from the new implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed it
Removed type annotations from the file as per review
Removed type annotations from file as per review
Removed type annotations as per review
Removed type annotations as per comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kindly review all the annotation changes.
Removed unnecessary header as per review
Removed header comment
Removed file level docstring
@@ -25,4 +25,4 @@ | |||
"schemas": ["tap_frontapp/schemas/*.json"] | |||
}, | |||
include_package_data=True | |||
) | |||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EOF
tests/unittests/test_client.py
Outdated
|
||
|
||
if __name__ == "__main__": | ||
unittest.main() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add EOF
Add EOF
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added EOF
Description of change
Refactored the Tap FrontApp connector to modularize discovery and sync logic:
Moved discover() to a dedicated discover.py file for clarity and reuse.
Introduced sync.py to handle sync operations with better structure and logging.
Cleaned up and simplified init.py to delegate responsibilities to modular files.
Manual QA steps
Ran the discover mode
Risks
As of now NA.
Rollback steps
AI generated code
https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code