Feature/sac 27535 frontapp #29
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RushiT0122
reviewed
May 22, 2025
tap_frontapp/__init__.py
Outdated
| refs = {} | ||
| for sub_stream_id in dependencies: | ||
| refs[sub_stream_id] = load_schema(sub_stream_id) | ||
| refs = {sub_id: load_schema(sub_id) for sub_id in dependencies} |
There was a problem hiding this comment.
Not a blocking change
Suggested change
| refs = {sub_id: load_schema(sub_id) for sub_id in dependencies} | |
| refs = {sub_stream_id: load_schema(sub_stream_id) for sub_stream_id in dependencies} |
RushiT0122
reviewed
May 22, 2025
tap_frontapp/sync.py
Outdated
| LOGGER.info("Selected streams: %s", streams_to_sync) | ||
|
|
||
| last_stream = singer.get_currently_syncing(state) | ||
| LOGGER.info("Last stream synced (if resuming): %s", last_stream) |
There was a problem hiding this comment.
Suggested change
| LOGGER.info("Last stream synced (if resuming): %s", last_stream) | |
| LOGGER.info("Currently syncing: %s", last_stream) |
RushiT0122
reviewed
May 22, 2025
tap_frontapp/discover.py
Outdated
| LOGGER = singer.get_logger() | ||
|
|
||
|
|
||
| def discover() -> Catalog: |
There was a problem hiding this comment.
To keep consistency with existing implementation, please remove type annotation from the new implementation.
Removed type annotations from the file as per review
Removed type annotations from file as per review
Removed type annotations as per review
Removed type annotations as per comment
romilqlik
commented
May 22, 2025
Removed unnecessary header as per review
Removed header comment
Removed file level docstring
RushiT0122
reviewed
May 22, 2025
| @@ -25,4 +25,4 @@ | |||
| "schemas": ["tap_frontapp/schemas/*.json"] | |||
| }, | |||
| include_package_data=True | |||
| ) | |||
| ) | |||
RushiT0122
reviewed
May 22, 2025
tests/unittests/test_client.py
Outdated
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| unittest.main() |
Add EOF
RushiT0122
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Refactored the Tap FrontApp connector to modularize discovery and sync logic:
Moved discover() to a dedicated discover.py file for clarity and reuse.
Introduced sync.py to handle sync operations with better structure and logging.
Cleaned up and simplified init.py to delegate responsibilities to modular files.
Manual QA steps
Ran the discover mode
Risks
As of now NA.
Rollback steps
AI generated code
https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code