Open
Conversation
Contributor
Author
|
Hi everyone! Just a friendly reminder about this PR :) thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
The current implementation is creating pagination for all endpoints, but AFAIK it is just necessary for the
assignmentsendpoint.In this PR,
sync_endpointchecks if the endpoint is "assignments" and, if it is correct, it will use the pagination for date ranges. If not, it will just use the starting date as the parameter.maybe it is not a big change, but it reduces the number of requests to the API.
PS: I tried it locally getting data from 2017 and it worked fine.
Manual QA steps
Risks
Rollback steps