Skip to content

Update OAuth instructions to use curl to get refresh token#28

Open
thena-seer-sfg wants to merge 1 commit intosinger-io:masterfrom
thena-seer-sfg:patch-1
Open

Update OAuth instructions to use curl to get refresh token#28
thena-seer-sfg wants to merge 1 commit intosinger-io:masterfrom
thena-seer-sfg:patch-1

Conversation

@thena-seer-sfg
Copy link
Copy Markdown

@thena-seer-sfg thena-seer-sfg commented Sep 30, 2024

Description of change

The current instructions are incorrect. The code received in the redirect url is not a refresh token, and the tap fails when it tries to use it as one. In order to get a refresh token, there is a code exchange step. The easiest way to do this is using curl, so I've added this step to the instructions.

This is based on Harvest's documentation: https://help.getharvest.com/api-v2/authentication-api/authentication/authentication/#oauth2-authorization-flow

Manual QA steps

  • Follow the instructions, verify they work.

Risks

  • Just a README change, risk is misinformation

Rollback steps

  • revert this branch

AI generated code

https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code

  • this PR has been written with the help of GitHub Copilot or another generative AI tool

@singer-bot
Copy link
Copy Markdown

Hi @thena-seer-sfg, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@singer-bot
Copy link
Copy Markdown

You did it @thena-seer-sfg!

Thank you for signing the Singer Contribution License Agreement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants