SAC-31234: Exlcude un-auth streams from catalog while discovery#34
Open
satyendra101 wants to merge 4 commits into
Open
SAC-31234: Exlcude un-auth streams from catalog while discovery#34satyendra101 wants to merge 4 commits into
satyendra101 wants to merge 4 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Adds discovery-time permission checks so streams that the provided credentials cannot read (HTTP 403) are excluded from the generated Singer catalog, improving UX by preventing unusable streams from appearing in discovery results.
Changes:
- Extend discovery flow to accept an optional
OutbrainClientand prune inaccessible streams (and dependent child streams) from the catalog. - Introduce stream base classes and implement a permission probe for
campaign. - Update unit tests and bump version/changelog for the new behavior.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
tap_outbrain/discover.py |
Adds access-check and pruning logic during discovery when a client is provided. |
tap_outbrain/streams.py |
Introduces BaseStream and implements Campaign.check_access() used by discovery filtering. |
tap_outbrain/client.py |
Adds OutbrainForbiddenError, config support on the client, and raises on HTTP 403. |
tap_outbrain/__init__.py |
Wires discover-mode CLI path to construct a client and pass it into discovery. |
tests/unittests/test_discover.py |
Adds unit tests for access-check/pruning and updates discovery tests for new signature. |
tests/unittests/test_init.py |
Updates do_discover unit test for the new client parameter. |
tests/unittests/test_catalog.py |
Updates parent/root stream assertions to match new BaseStream.parent behavior. |
setup.py |
Bumps package version to 1.2.0. |
CHANGELOG.md |
Documents the new discovery filtering behavior (with a minor wording fix requested). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Manual QA steps
Risks
Rollback steps
AI generated code
https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code