Feature/detailed call log#12
Open
KolinMboorom wants to merge 3 commits into
Open
Conversation
|
Hi @KolinMboorom, thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. |
|
You did it @KolinMboorom! Thank you for signing the Singer Contribution License Agreement. |
Author
|
@cmerrick Hi there! so are there any blockers to merging this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
The purpose of this PR is to enhance the existing dataset by adding endpoints for Call records #10. Additionally, by changing the nature of the GET request from "simple" to "Detailed" it opens the door for others in the community to pull PR's for additional fields on the Tap. The expected behavior of this PR is to not change the existing fields or data in any way, only to make more fields available. I believe this would also satisfy the requirements for Issues #6 and #7
Manual QA steps
Received valid 2XX positive code from Server
Got expected output of non recorded call and call + recording
Risks
Rollback steps