Skip to content

SAC-31235: Exlcude un-auth streams from catalog#26

Open
satyendra101 wants to merge 3 commits into
masterfrom
SAC-31235/exclude-un-auth-streams
Open

SAC-31235: Exlcude un-auth streams from catalog#26
satyendra101 wants to merge 3 commits into
masterfrom
SAC-31235/exclude-un-auth-streams

Conversation

@satyendra101

@satyendra101 satyendra101 commented Jun 17, 2026

Copy link
Copy Markdown

Description of change

Manual QA steps

  • Discovery running
  • Unittests running
  • Integration tests running

Risks

Rollback steps

  • revert this branch

AI generated code

https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code

  • this PR has been written with the help of GitHub Copilot or another generative AI tool

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates discovery to exclude streams the provided RingCentral credentials cannot read (HTTP 403), so the generated Singer catalog contains only accessible streams.

Changes:

  • Add stream-level access probing during discovery (and prune child streams when a parent is inaccessible).
  • Treat HTTP 403 as a non-retryable permission error via a new RingCentralForbiddenError.
  • Update unit tests and bump version/changelog for the new behavior.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tap_ringcentral/discover.py Adds access-check and child-pruning logic and wires it into discovery.
tap_ringcentral/streams/base.py Adds check_access() to probe stream readability via the API.
tap_ringcentral/client.py Introduces RingCentralForbiddenError and raises it on HTTP 403 (no refresh/retry).
tap_ringcentral/__init__.py Passes the real client into discover() so access checks run in CLI discovery.
tests/unittests/test_discover.py Adds unit tests for access-checking and child-pruning behavior.
tests/unittests/test_client.py Updates 403 behavior test to expect RingCentralForbiddenError without retries.
setup.py Bumps package version to 1.3.0.
CHANGELOG.md Documents the new “exclude unauthorized streams” behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tap_ringcentral/discover.py Outdated
Comment thread CHANGELOG.md Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants