SAC-31235: Exlcude un-auth streams from catalog#26
Open
satyendra101 wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates discovery to exclude streams the provided RingCentral credentials cannot read (HTTP 403), so the generated Singer catalog contains only accessible streams.
Changes:
- Add stream-level access probing during discovery (and prune child streams when a parent is inaccessible).
- Treat HTTP 403 as a non-retryable permission error via a new
RingCentralForbiddenError. - Update unit tests and bump version/changelog for the new behavior.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
tap_ringcentral/discover.py |
Adds access-check and child-pruning logic and wires it into discovery. |
tap_ringcentral/streams/base.py |
Adds check_access() to probe stream readability via the API. |
tap_ringcentral/client.py |
Introduces RingCentralForbiddenError and raises it on HTTP 403 (no refresh/retry). |
tap_ringcentral/__init__.py |
Passes the real client into discover() so access checks run in CLI discovery. |
tests/unittests/test_discover.py |
Adds unit tests for access-checking and child-pruning behavior. |
tests/unittests/test_client.py |
Updates 403 behavior test to expect RingCentralForbiddenError without retries. |
setup.py |
Bumps package version to 1.3.0. |
CHANGELOG.md |
Documents the new “exclude unauthorized streams” behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
JIRA: https://qlik-dev.atlassian.net/browse/SAC-31235
Manual QA steps
Risks
Rollback steps
AI generated code
https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code