Add SOAP login support#65
Open
cenxiao wants to merge 2 commits into
Open
Conversation
|
Hi @cenxiao, thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. |
|
You did it @cenxiao! Thank you for signing the Singer Contribution License Agreement. |
|
This one has been over a year! This would be a welcome change, so we don't have to go through getting a valid refresh token if something busted for more than a few days. |
|
Honestly, it would be amazing if we got this merged. |
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My most recent work requires me to pull data from a legacy Salesforce environment which doesn't have OAuth enabled, so I added the SOAP login support with the login code copied from Simple-Salesforce. I also added the two sets of required configs which looks pretty awkward, however, by looking at the original Singer.io documentation, I don't see this situation being mentioned. Please take a look and see if it makes sense to you. Thanks