Skip to content

Introduce new stream order_shipping_lines #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

prijendev
Copy link
Contributor

@prijendev prijendev commented May 6, 2025

Description of change

  • Add order_shipping_lines as a new stream.
  • shippingLine is a nested object within the orders stream. It represents individual shipping methods or carrier options associated with an order. It represents multiple shipping options or methods. This new stream introduction would,
    • Optimize performance by keeping the orders query lighter.
    • Reduce the risk of API throttling due to lower query complexity.
    • Enable independent handling of shippingLines for future customizations and enhancements.

QA steps

  • automated tests passing
  • Run the discover mode and validate the schema/metadata in the catalog
  • Run the sync mode with/without state and validate the state/records.
  • Validate the fields in the sync for order_shipping_lines stream.

Risks

Rollback steps

  • revert this branch

AI generated code

https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code

  • this PR has been written with the help of GitHub Copilot or another generative AI tool

@prijendev prijendev changed the title Support 3231 new stream shippinglines Introduce new stream order_shipping_lines May 6, 2025
@prijendev prijendev changed the base branch from master to Support-3582-query-builder May 9, 2025 06:29
@sgandhi1311 sgandhi1311 changed the base branch from Support-3582-query-builder to master June 4, 2025 11:00
CHANGELOG.md Outdated
@@ -1,5 +1,9 @@
# Changelog

## 3.4.0
* Dynamically generate graphql query [#214](https://github.com/singer-io/tap-shopify/pull/214)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this line in changelog misleading?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants