Skip to content

Support 5474 remove addresses#245

Open
sgandhi1311 wants to merge 7 commits intomasterfrom
Support-5474-remove-addresses
Open

Support 5474 remove addresses#245
sgandhi1311 wants to merge 7 commits intomasterfrom
Support-5474-remove-addresses

Conversation

@sgandhi1311
Copy link
Copy Markdown
Member

@sgandhi1311 sgandhi1311 commented Nov 21, 2025

Description of change

This PR removes the addresses field from the customer object in the orders stream, as it is a redundant data.

Changes:

  • Removed addresses field from the GraphQL query for orders
  • Removed addresses schema definition from the orders JSON schema

QA steps

  • automated tests passing
  • manual qa steps passing (list below)

Risks

Rollback steps

  • revert this branch

AI generated code

https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code

  • this PR has been written with the help of GitHub Copilot or another generative AI tool

@sgandhi1311 sgandhi1311 requested a review from Copilot January 30, 2026 09:52
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the addresses field from the customer object in the orders stream, likely in response to a deprecation or change in the Shopify API (ticket 5474).

Changes:

  • Removed addresses field from the GraphQL query for orders
  • Removed addresses schema definition from the orders JSON schema

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
tap_shopify/streams/orders.py Removed addresses query fields from customer object in GraphQL query
tap_shopify/schemas/orders.json Removed addresses schema definition from customer properties

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants