Open
Conversation
… the extraction if the existing fails due to the time limit of 23 hours
…r-io/tap-shopify into Support-5474-remove-addresses
…t-5474-remove-addresses
There was a problem hiding this comment.
Pull request overview
This PR removes the addresses field from the customer object in the orders stream, likely in response to a deprecation or change in the Shopify API (ticket 5474).
Changes:
- Removed
addressesfield from the GraphQL query for orders - Removed
addressesschema definition from the orders JSON schema
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tap_shopify/streams/orders.py | Removed addresses query fields from customer object in GraphQL query |
| tap_shopify/schemas/orders.json | Removed addresses schema definition from customer properties |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
This PR removes the addresses field from the customer object in the orders stream, as it is a redundant data.
Changes:
QA steps
Risks
Rollback steps
AI generated code
https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code