Skip to content

Add shop info to the records#73

Open
EmaLoprevite wants to merge 1 commit intosinger-io:masterfrom
EmaLoprevite:add-shop-info
Open

Add shop info to the records#73
EmaLoprevite wants to merge 1 commit intosinger-io:masterfrom
EmaLoprevite:add-shop-info

Conversation

@EmaLoprevite
Copy link
Copy Markdown

@EmaLoprevite EmaLoprevite commented Nov 19, 2020

Description of change

Add shop info to the records to be able to easily distinguish them among multiple shops.

QA steps

  • automated tests passing: the tests include packages (e.g. tap_tester) not publicly available so it is difficult to check them or create new ones;
  • manual qa steps passing (list below): sorry, I am not sure where these steps are listed.

Risks

  • None, because the three new "sdc" fields appears in the output only if they are selected in the catalog.

Rollback steps

  • Revert this branch.

Add shop info to the records to be able to easily distinguish them among multiple shops
@briansloane
Copy link
Copy Markdown

@EmaLoprevite So that I understand better, can you explain how you would have multiple shop data in one extraction which makes this necessary? I thought that the tap will only extract data for one shop/subdomain.

@EmaLoprevite
Copy link
Copy Markdown
Author

Hi @briansloane, thank you very much for reviewing my PR.
This change is very useful when downloading data from multiple shops and putting everything into a single table via a SQL target; this way the data can be later filtered by shop, otherwise there's no way to know to which shop a specific row in a table belongs.
Of course, that field can be added/selected via the catalog so it doesn't affect the current behaviour.
If you have other questions, please feel free to ask; thank you again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants