Fix untyped array items in financial management journal schema - #27
Closed
MuralidharT03 wants to merge 2 commits into
Closed
Fix untyped array items in financial management journal schema#27MuralidharT03 wants to merge 2 commits into
MuralidharT03 wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Singer JSON schema for the financial_management_journals stream to avoid “untyped” array item schemas by specifying item types, improving downstream schema validation/consumption. Also updates repo hygiene by ignoring Python *.egg-info/ artifacts.
Changes:
- Typed several previously untyped array
itemsdefinitions infinancial_management_journals.json(now constrained tonull/objectitems). - Added
*.egg-info/to.gitignore.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tap_workday/schemas/financial_management_journals.json | Replaces empty {} array item schemas with an explicit item type (null/object) for multiple fields. |
| .gitignore | Ignores *.egg-info/ directories/files generated by Python packaging/install tooling. |
Collaborator
|
Clubbed changes in: #28 |
Collaborator
|
Closing in favour of: #29 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Updates the Singer JSON schema for the
financial_management_journalsstream to avoid “untyped” array item schemas by specifying item types, improving downstream schema validation/consumption.Changes:
itemsdefinitions infinancial_management_journals.json(now constrained tonull/objectitems).*.egg-info/to.gitignore.Jira ticket: SAC-29745
Manual QA steps
Risks
Rollback steps