Retries a 401 error by refreshing the access token#121
Open
vishalp-dev wants to merge 13 commits into
Open
Conversation
vishalp-dev
commented
Mar 27, 2025
Comment on lines
+67
to
+68
| def ensure_credentials_are_valid(config, config_path): | ||
| XeroClient(config, config_path).filter("currencies") |
Member
Author
There was a problem hiding this comment.
This method is unused throughout the code
vishalp-dev
marked this pull request as draft
March 27, 2025 11:44
vishalp-dev
marked this pull request as ready for review
October 9, 2025 14:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Long Running extractions do not complete due to the short lived nature of the xero access tokens, and the tap is incapable to rotate a expired access_token amidst an ongoing extraction, this pr updates the tap implementation to handle 401 issues and retry the api call after refreshing the
access_token.Summary of Changes:
accees_tokento config fileNote:
Xero Access tokens are short lived and currently there is no way to debug any issue with a locally cloned connection without breaking the token chain on the orignal connection.
Manual QA steps
Risks
Minimal
Rollback steps
AI generated code
https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code