Wrap bottom sheet content in SafeAreas#2683
Open
jlahd wants to merge 1 commit into
Open
Conversation
jlahd
force-pushed
the
bottom-sheet-safe-area
branch
from
e5afc5a to
8531084
Compare
jlahd
force-pushed
the
bottom-sheet-safe-area
branch
from
8531084 to
237d5bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, when the (old) three-button navigation mode is in use on Android, and the app uses fullscreen mode, the bottommost option on all bottom sheets opened by flutter-quill effectively get blocked by Android's system buttons, being shown behind the button bar:
This PR wraps the bottom sheets in a proper
SafeAreawidget, which adds the necessary padding so that all options are reachable.Type of Change