Fix: selection handle horizontal drag stays on current line#2731
Open
Alspb wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR restores adjusted drag-position handling for text selection handles so horizontal dragging resolves the text position from the handle anchor rather than the raw pointer position.
Changes:
- Tracks
_dragPositionduring handle drag updates and uses it forgetPositionForOffset. - Removes the now-obsolete unused-field ignore.
- Adds an Unreleased changelog entry for the fix.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
lib/src/editor/widgets/text/text_selection.dart |
Restores adjusted drag position usage for selection handle drag updates. |
CHANGELOG.md |
Documents the selection handle drag fix under Unreleased. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| _dragPosition += details.delta; | ||
| final position = | ||
| widget.renderObject.getPositionForOffset(details.globalPosition); | ||
| final position = widget.renderObject.getPositionForOffset(_dragPosition); |
|
|
||
| ### Fixed | ||
|
|
||
| - Fixed dragging the right selection handle horizontally extends the selection into the line below instead of staying on the current line. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed: Dragging the right selection handle horizontally extends the selection into the line below instead of staying on the current line.
_handleDragUpdatewas resolving the text position from the rawdetails.globalPosition, which lies below the line thehandle anchors to.
The fix was introduced previously in 6b9795a:
_dragPosition += details.deltaincludes the necessary adjustment. This fix was later reverted for some reason. Restoring it.Type of Change