Skip to content

Chore/dart 3.12 format#2744

Merged
Alspb merged 2 commits into
singerdmx:masterfrom
Alspb:chore/dart-3.12-format
Jun 15, 2026
Merged

Chore/dart 3.12 format#2744
Alspb merged 2 commits into
singerdmx:masterfrom
Alspb:chore/dart-3.12-format

Conversation

@Alspb

@Alspb Alspb commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

Adopt Dart 3.12 formatting repo-wide

Reformats the entire codebase to the new dart format "tall" style (Dart 3.12 /
dart_style 3.1.6) in one pass, and adds the machinery to keep it from drifting back.

Changes

  • Repo-wide reformat — dart format . across 180 files. Formatting only, no logic
    changes (dart fix reports nothing to fix).
  • .git-blame-ignore-revs — lets git blame/GitHub skip the reformat commit so line
    history still points at the real authors.
  • CI — re-enable dart format --set-exit-if-changed . and pin flutter-version: 3.44.1
    so formatter output stays deterministic and can't red unrelated PRs.
  • before_push.dart — format the whole repo (mirrors CI) instead of only changed files.

Reviewing

The reformat is mechanical — review the second commit (CI/blame-ignore/script), not the
180-file diff. Enable locally with git config blame.ignoreRevsFile .git-blame-ignore-revs.

Open PRs / branches

After this merges, rebase: merge the pre-reformat commit, run dart format ., then merge
master — conflicts then only appear in lines you actually changed.

Type of Change

  • ✨ Feature: New functionality without breaking existing features.
  • 🛠️ Bug fix: Resolves an issue without altering current behavior.
  • 🧹 Refactor: Code reorganization, no behavior change.
  • ❌ Breaking: Alters existing functionality and requires updates.
  • 🧪 Tests: New or modified tests
  • 📝 Documentation: Updates or additions to documentation.
  • 🗑️ Chore: Routine tasks, or maintenance.
  • ✅ Build configuration change: Build/configuration changes.

Copilot AI review requested due to automatic review settings June 15, 2026 07:57
@Alspb Alspb added the no changelog This pull request does not require an update to the changelog, as it does not introduce significant label Jun 15, 2026
Copilot AI reviewed Jun 15, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adopts Dart 3.12 / dart_style 3.1.6 “tall” formatting across the repository to standardize code style, and updates automation to keep formatting deterministic and enforced going forward.

Changes:

  • Repo-wide Dart 3.12 “tall” reformat across library, tests, examples, and extensions.
  • CI: pin Flutter version and re-enable dart format --set-exit-if-changed . in checks workflow.
  • Tooling: add .git-blame-ignore-revs and update scripts/before_push.dart to format repo-wide.

Reviewed changes

Copilot reviewed 170 out of 183 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
test/toolbar/buttons/link_style_button_test.dart Dart 3.12 tall-format reflow (tests).
test/toolbar/buttons/color/color_dialog_test.dart Dart 3.12 tall-format reflow (tests).
test/editor/editor_test.dart Dart 3.12 tall-format reflow (tests).
test/editor/editor_config_utils.dart Dart 3.12 tall-format reflow (tests).
test/editor_toolbar_shared/color_test.dart Dart 3.12 tall-format reflow (tests).
test/document/line_test.dart Dart 3.12 tall-format reflow (tests).
test/document/attributes_test.dart Dart 3.12 tall-format reflow (tests).
test/common/utils/quill_test_app.dart Dart 3.12 tall-format reflow (tests).
test/common/utils/quill_native_provider_test.dart Dart 3.12 tall-format reflow (tests).
test/common/utils/platform_test.dart Dart 3.12 tall-format reflow (tests).
test/common/utils/link_validator_test.dart Dart 3.12 tall-format reflow (tests).
scripts/update_pubspec_version.dart Dart 3.12 tall-format reflow (scripts).
scripts/update_changelog_version.dart Dart 3.12 tall-format reflow (scripts).
scripts/translations_check.dart Dart 3.12 tall-format reflow (scripts).
scripts/publish_flutter_quill.dart Dart 3.12 tall-format reflow (scripts).
scripts/before_push.dart Change before-push behavior to format the whole repo and add a formatting assertion step.
lib/src/toolbar/theme/quill_dialog_theme.dart Dart 3.12 tall-format reflow (toolbar).
lib/src/toolbar/simple_toolbar.dart Dart 3.12 tall-format reflow (toolbar).
lib/src/toolbar/embed/embed_button_builder.dart Dart 3.12 tall-format reflow (toolbar API typedef).
lib/src/toolbar/config/simple_toolbar_button_options.dart Dart 3.12 tall-format reflow (toolbar config).
lib/src/toolbar/config/buttons/toggle_style_options.dart Dart 3.12 tall-format reflow (toolbar config).
lib/src/toolbar/config/buttons/toggle_check_list_options.dart Dart 3.12 tall-format reflow (toolbar config).
lib/src/toolbar/config/buttons/select_line_height_style_dropdown_button_options.dart Dart 3.12 tall-format reflow (toolbar config).
lib/src/toolbar/config/buttons/select_header_style_dropdown_button_options.dart Dart 3.12 tall-format reflow (toolbar config).
lib/src/toolbar/config/buttons/select_header_style_buttons_options.dart Dart 3.12 tall-format reflow (toolbar config).
lib/src/toolbar/config/buttons/select_alignment_options.dart Dart 3.12 tall-format reflow (toolbar config).
lib/src/toolbar/config/buttons/search_options.dart Dart 3.12 tall-format reflow (toolbar config).
lib/src/toolbar/config/buttons/link_style2_options.dart Dart 3.12 tall-format reflow (toolbar config).
lib/src/toolbar/config/buttons/link_style_options.dart Dart 3.12 tall-format reflow (toolbar config).
lib/src/toolbar/config/buttons/indent_options.dart Dart 3.12 tall-format reflow (toolbar config).
lib/src/toolbar/config/buttons/history_options.dart Dart 3.12 tall-format reflow (toolbar config).
lib/src/toolbar/config/buttons/font_size_options.dart Dart 3.12 tall-format reflow (toolbar config).
lib/src/toolbar/config/buttons/font_family_options.dart Dart 3.12 tall-format reflow (toolbar config).
lib/src/toolbar/config/buttons/custom_button_options.dart Dart 3.12 tall-format reflow (toolbar config).
lib/src/toolbar/config/buttons/color_options.dart Dart 3.12 tall-format reflow (toolbar config).
lib/src/toolbar/config/buttons/clear_format_options.dart Dart 3.12 tall-format reflow (toolbar config).
lib/src/toolbar/config/base_button_options.dart Dart 3.12 tall-format reflow (toolbar config typedef).
lib/src/toolbar/buttons/toggle_style_button.dart Dart 3.12 tall-format reflow (toolbar button).
lib/src/toolbar/buttons/toggle_check_list_button.dart Dart 3.12 tall-format reflow (toolbar button).
lib/src/toolbar/buttons/select_line_height_dropdown_button.dart Dart 3.12 tall-format reflow (toolbar button).
lib/src/toolbar/buttons/search/search_dialog.dart Dart 3.12 tall-format reflow (search UI).
lib/src/toolbar/buttons/search/search_button.dart Dart 3.12 tall-format reflow (search button).
lib/src/toolbar/buttons/link_style/link_style_button.dart Dart 3.12 tall-format reflow (link UI).
lib/src/toolbar/buttons/indent_button.dart Dart 3.12 tall-format reflow (indent UI).
lib/src/toolbar/buttons/history_button.dart Dart 3.12 tall-format reflow (history UI).
lib/src/toolbar/buttons/hearder_style/select_header_style_dropdown_button.dart Dart 3.12 tall-format reflow (header UI).
lib/src/toolbar/buttons/hearder_style/select_header_style_buttons.dart Dart 3.12 tall-format reflow (header UI).
lib/src/toolbar/buttons/font_size_button.dart Dart 3.12 tall-format reflow (font UI).
lib/src/toolbar/buttons/font_family_button.dart Dart 3.12 tall-format reflow (font UI).
lib/src/toolbar/buttons/color/color_dialog.dart Dart 3.12 tall-format reflow (color UI).
lib/src/toolbar/buttons/color/color_button.dart Dart 3.12 tall-format reflow (color UI).
lib/src/toolbar/buttons/clipboard_button.dart Dart 3.12 tall-format reflow (clipboard UI).
lib/src/toolbar/buttons/arrow_indicated_list_button.dart Dart 3.12 tall-format reflow (toolbar UI).
lib/src/toolbar/buttons/alignment/select_alignment_buttons.dart Dart 3.12 tall-format reflow (alignment UI).
lib/src/toolbar/buttons/alignment/select_alignment_button.dart Dart 3.12 tall-format reflow (alignment UI).
lib/src/toolbar/base_button/stateless_base_button.dart Dart 3.12 tall-format reflow (base button API).
lib/src/toolbar/base_button/base_value_button.dart Dart 3.12 tall-format reflow (base button API).
lib/src/rules/rule.dart Dart 3.12 tall-format reflow (document rules).
lib/src/rules/insert.dart Dart 3.12 tall-format reflow (document rules).
lib/src/rules/format.dart Dart 3.12 tall-format reflow (document rules).
lib/src/rules/delete.dart Dart 3.12 tall-format reflow (document rules).
lib/src/packages/quill_markdown/utils.dart Dart 3.12 tall-format reflow (markdown utils).
lib/src/packages/quill_markdown/markdown_to_delta.dart Dart 3.12 tall-format reflow (markdown conversion).
lib/src/packages/quill_markdown/embeddable_table_syntax.dart Dart 3.12 tall-format reflow (markdown parsing).
lib/src/packages/quill_markdown/delta_to_markdown.dart Dart 3.12 tall-format reflow (markdown conversion).
lib/src/packages/quill_markdown/custom_quill_attributes.dart Dart 3.12 tall-format reflow (attributes).
lib/src/l10n/generated/quill_localizations.dart Dart 3.12 tall-format reflow (generated l10n).
lib/src/editor/widgets/text/utils/text_block_utils.dart Dart 3.12 tall-format reflow (editor widgets).
lib/src/editor/widgets/text/magnifier.dart Dart 3.12 tall-format reflow (editor widgets).
lib/src/editor/widgets/proxy.dart Dart 3.12 tall-format reflow (editor widgets).
lib/src/editor/widgets/link.dart Dart 3.12 tall-format reflow (editor link handling).
lib/src/editor/widgets/keyboard_listener.dart Dart 3.12 tall-format reflow (keyboard handling).
lib/src/editor/widgets/delegate.dart Dart 3.12 tall-format reflow (gesture delegate).
lib/src/editor/widgets/default_styles.dart Dart 3.12 tall-format reflow (default styles).
lib/src/editor/widgets/default_leading_components/number_point_leading.dart Dart 3.12 tall-format reflow (leading components).
lib/src/editor/widgets/default_leading_components/codeblock_line_number_leading.dart Dart 3.12 tall-format reflow (leading components).
lib/src/editor/widgets/default_leading_components/check_box_leading.dart Dart 3.12 tall-format reflow (leading components).
lib/src/editor/widgets/default_leading_components/bullet_point_leading.dart Dart 3.12 tall-format reflow (leading components).
lib/src/editor/widgets/cursor.dart Dart 3.12 tall-format reflow (cursor rendering).
lib/src/editor/style_widgets/checkbox_point.dart Dart 3.12 tall-format reflow (style widgets).
lib/src/editor/style_widgets/bullet_point.dart Dart 3.12 tall-format reflow (style widgets).
lib/src/editor/raw_editor/scribble_focusable.dart Dart 3.12 tall-format reflow (raw editor).
lib/src/editor/raw_editor/raw_editor.dart Dart 3.12 tall-format reflow (raw editor).
lib/src/editor/raw_editor/raw_editor_text_boundaries.dart Dart 3.12 tall-format reflow (selection boundaries).
lib/src/editor/raw_editor/raw_editor_state_selection_delegate_mixin.dart Dart 3.12 tall-format reflow (selection delegate).
lib/src/editor/raw_editor/keyboard_shortcuts/editor_keyboard_shortcuts.dart Dart 3.12 tall-format reflow (keyboard shortcuts).
lib/src/editor/raw_editor/config/events/standard_char_shortcuts/standard_shortcut_events.dart Dart 3.12 tall-format reflow (events).
lib/src/editor/raw_editor/config/events/standard_char_shortcuts/single_character_shortcut_events.dart Dart 3.12 tall-format reflow (events).
lib/src/editor/raw_editor/config/events/standard_char_shortcuts/double_character_shortcut_events.dart Dart 3.12 tall-format reflow (events).
lib/src/editor/raw_editor/config/events/space_shortcut_events.dart Dart 3.12 tall-format reflow (events).
lib/src/editor/raw_editor/config/events/format/format_space_shortcut_event_handler.dart Dart 3.12 tall-format reflow (events).
lib/src/editor/raw_editor/config/events/format/format_single_character_handler.dart Dart 3.12 tall-format reflow (events).
lib/src/editor/raw_editor/config/events/format/format_double_character_handler.dart Dart 3.12 tall-format reflow (events).
lib/src/editor/raw_editor/config/events/character_shortcuts_events.dart Dart 3.12 tall-format reflow (events).
lib/src/editor/raw_editor/builders/leading_block_builder.dart Dart 3.12 tall-format reflow (builder).
lib/src/editor/embed/embed_editor_builder.dart Dart 3.12 tall-format reflow (embed builder API).
lib/src/editor/config/search_config.dart Dart 3.12 tall-format reflow (config).
lib/src/editor/config/editor_config.dart Dart 3.12 tall-format reflow (config).
lib/src/editor_toolbar_controller_shared/clipboard/default_clipboard_service.dart Dart 3.12 tall-format reflow (clipboard service).
lib/src/document/style.dart Dart 3.12 tall-format reflow (document model).
lib/src/document/structs/history_changed.dart Dart 3.12 tall-format reflow (document structs).
lib/src/document/structs/doc_change.dart Dart 3.12 tall-format reflow (document structs).
lib/src/document/nodes/line.dart Dart 3.12 tall-format reflow (document nodes).
lib/src/document/nodes/leaf.dart Dart 3.12 tall-format reflow (document nodes).
lib/src/document/nodes/container.dart Dart 3.12 tall-format reflow (document nodes).
lib/src/document/history.dart Dart 3.12 tall-format reflow (history).
lib/src/document/document.dart Dart 3.12 tall-format reflow (document).
lib/src/document/custom_attributes.dart Dart 3.12 tall-format reflow (attributes).
lib/src/document/attribute.dart Dart 3.12 tall-format reflow (attributes).
lib/src/delta/delta_x.dart Dart 3.12 tall-format reflow (delta utilities).
lib/src/delta/delta_diff.dart Dart 3.12 tall-format reflow (delta diff).
lib/src/controller/clipboard/quill_controller_paste.dart Dart 3.12 tall-format reflow (controller).
lib/src/common/utils/widgets.dart Dart 3.12 tall-format reflow (utils).
lib/src/common/utils/string.dart Dart 3.12 tall-format reflow (utils).
lib/src/common/utils/link_validator.dart Dart 3.12 tall-format reflow (utils).
lib/src/common/utils/font.dart Dart 3.12 tall-format reflow (utils).
lib/src/common/utils/color.dart Dart 3.12 tall-format reflow (utils).
lib/src/common/structs/vertical_spacing.dart Dart 3.12 tall-format reflow (structs).
lib/src/common/structs/optional_size.dart Dart 3.12 tall-format reflow (structs).
lib/src/common/structs/image_url.dart Dart 3.12 tall-format reflow (structs).
lib/src/common/structs/horizontal_spacing.dart Dart 3.12 tall-format reflow (structs).
flutter_quill_test/test/flutter_quill_test_test.dart Dart 3.12 tall-format reflow (test package).
flutter_quill_test/lib/src/test/widget_tester_extension.dart Dart 3.12 tall-format reflow (test package).
flutter_quill_test/lib/src/test/text_interactions/widget_tester_replace_extension.dart Dart 3.12 tall-format reflow (test package).
flutter_quill_test/lib/src/test/text_interactions/widget_tester_remove_extension.dart Dart 3.12 tall-format reflow (test package).
flutter_quill_test/lib/src/test/text_interactions/widget_tester_insert_extension.dart Dart 3.12 tall-format reflow (test package).
flutter_quill_test/lib/src/test/selection_interactions/widget_tester_nodes_selection_extension.dart Dart 3.12 tall-format reflow (test package).
flutter_quill_test/lib/src/test/selection_interactions/widget_tester_cursor_movement_extension.dart Dart 3.12 tall-format reflow (test package).
flutter_quill_extensions/test/quill_test_app.dart Dart 3.12 tall-format reflow (extensions tests).
flutter_quill_extensions/lib/src/toolbar/video/video_button.dart Dart 3.12 tall-format reflow (extensions).
flutter_quill_extensions/lib/src/toolbar/video/select_video_source.dart Dart 3.12 tall-format reflow (extensions).
flutter_quill_extensions/lib/src/toolbar/video/config/video.dart Dart 3.12 tall-format reflow (extensions).
flutter_quill_extensions/lib/src/toolbar/video/config/video_config.dart Dart 3.12 tall-format reflow (extensions).
flutter_quill_extensions/lib/src/toolbar/image/select_image_source.dart Dart 3.12 tall-format reflow (extensions).
flutter_quill_extensions/lib/src/toolbar/image/image_button.dart Dart 3.12 tall-format reflow (extensions).
flutter_quill_extensions/lib/src/toolbar/image/config/image_config.dart Dart 3.12 tall-format reflow (extensions).
flutter_quill_extensions/lib/src/toolbar/camera/select_camera_action.dart Dart 3.12 tall-format reflow (extensions).
flutter_quill_extensions/lib/src/toolbar/camera/config/camera_config.dart Dart 3.12 tall-format reflow (extensions).
flutter_quill_extensions/lib/src/toolbar/camera/camera_types.dart Dart 3.12 tall-format reflow (extensions).
flutter_quill_extensions/lib/src/toolbar/camera/camera_button.dart Dart 3.12 tall-format reflow (extensions).
flutter_quill_extensions/lib/src/flutter_quill_embeds.dart Dart 3.12 tall-format reflow (extensions).
flutter_quill_extensions/lib/src/editor/video/youtube_video_url.dart Dart 3.12 tall-format reflow (extensions).
flutter_quill_extensions/lib/src/editor/video/widgets/video_app.dart Dart 3.12 tall-format reflow (extensions).
flutter_quill_extensions/lib/src/editor/video/video_web_embed.dart Dart 3.12 tall-format reflow (extensions).
flutter_quill_extensions/lib/src/editor/video/video_embed.dart Dart 3.12 tall-format reflow (extensions).
flutter_quill_extensions/lib/src/editor/image/widgets/image.dart Dart 3.12 tall-format reflow (extensions).
flutter_quill_extensions/lib/src/editor/image/widgets/image_resizer.dart Dart 3.12 tall-format reflow (extensions).
flutter_quill_extensions/lib/src/editor/image/image_web_embed.dart Dart 3.12 tall-format reflow (extensions).
flutter_quill_extensions/lib/src/editor/image/image_save_utils.dart Dart 3.12 tall-format reflow (extensions).
flutter_quill_extensions/lib/src/editor/image/image_menu.dart Dart 3.12 tall-format reflow (extensions).
flutter_quill_extensions/lib/src/editor/image/image_load_utils.dart Dart 3.12 tall-format reflow (extensions).
flutter_quill_extensions/lib/src/editor/image/image_embed.dart Dart 3.12 tall-format reflow (extensions).
flutter_quill_extensions/lib/src/editor/image/image_embed_types.dart Dart 3.12 tall-format reflow (extensions).
flutter_quill_extensions/lib/src/editor/image/config/image_web_config.dart Dart 3.12 tall-format reflow (extensions).
flutter_quill_extensions/lib/src/common/utils/web/web_stub.dart Dart 3.12 tall-format reflow (extensions web utils).
flutter_quill_extensions/lib/src/common/utils/web/web_real.dart Dart 3.12 tall-format reflow (extensions web utils).
flutter_quill_extensions/lib/src/common/utils/element_utils/element_web_utils.dart Dart 3.12 tall-format reflow (extensions).
flutter_quill_extensions/lib/src/common/utils/element_utils/element_utils.dart Dart 3.12 tall-format reflow (extensions).
flutter_quill_extensions/lib/src/common/image_video_utils.dart Dart 3.12 tall-format reflow (extensions).
flutter_quill_extensions/lib/src/common/extensions/controller_ext.dart Dart 3.12 tall-format reflow (extensions).
flutter_quill_extensions/lib/src/common/extensions/attribute.dart Dart 3.12 tall-format reflow (extensions).
example/lib/main.dart Dart 3.12 tall-format reflow (example app).
example/lib/custom_toolbar.dart Dart 3.12 tall-format reflow (example app).
example/integration_test/flutter_quill_integration_test.dart Dart 3.12 tall-format reflow (example integration test).
.github/workflows/checks.yml Pin Flutter version and re-enable CI formatting enforcement.
.git-blame-ignore-revs Add ignore-revs entry for the large formatting commit.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread scripts/before_push.dart
Comment on lines +18 to +19
await runCommand('dart', ['format', '.']);
await runCommand('dart', ['format', '--set-exit-if-changed', '.']);
Comment thread scripts/before_push.dart
Comment on lines 37 to 39
Future<void> runCommand(
String executable,
List<String> arguments, {
@Alspb Alspb merged commit 760c092 into singerdmx:master Jun 15, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

no changelog This pull request does not require an update to the changelog, as it does not introduce significant

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Alspb