Fix: a visual bug where bullet point spacing chagnes when toggling line-level directionality.#2745
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes an RTL/LTR rendering edge case in list items by ensuring the list “leading” (e.g., bullet/number/checkbox) is laid out using the editor’s base TextDirection, preventing the marker-to-text gap from expanding when line-level directionality is toggled.
Changes:
- Wrap the list leading widget in a
Directionalityset to the editor/basetextDirection. - Refactor leading construction into a local variable for clearer conditional wrapping.
- Update the example app toolbar to display the direction toggle button, and document the fix in the changelog.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/src/editor/widgets/text/text_block.dart | Locks list leading widgets to the editor’s base direction to keep marker spacing stable when a line toggles RTL/LTR. |
| example/lib/main.dart | Enables the direction toggle in the example toolbar (showDirection: true). |
| CHANGELOG.md | Adds an Unreleased “Fixed” entry describing the bullet spacing issue and resolution. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a visual bug where bullet point spacing chagnes when toggling line-level directionality.
The Problem:
In a standard LTR editor, when a line in an unordered list is toggled to RTL format, the visual space between the bullet point (
•) and the actual text dramatically inflates.The Solution:
Wrap
Directionalityaround the layout'sleadingwidget.Before the fix:
After the fix:
Type of Change