[198] Remove glob's on BUILD files #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pedrobc89
force-pushed
the
pedro/198/no_more_glob
branch
from
746211c to
c78852f
Compare
Pedrobc89
force-pushed
the
pedro/198/no_more_glob
branch
from
c78852f to
a538c0c
Compare
angeloprobst
approved these changes
Mar 13, 2025
There was a problem hiding this comment.
Looks good.
Ran some local checks:
- Wiped bazel cache out (
make bazel clean). - Deleted bins/wheels (
rm -f ./src/bin/*). - Build all (
make build-all). - Executed tests (
make test-all). - Spawned Attention Broker and Query Agent and executed some queries.
- Created a fresh Python 3.10 venv, installed
hyperon-das-atomdb-cppwheel, imported it in Python console, instantiated nodes and save them into the DB, fetched them back.
Everything worked as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #198
Removed almost all glob and filegroup from BUILD files, listing it's dependencies instead.
Couldn't refactor distributed_algorithm_node, due to its circular imports nature.
Couldn't remove the grouping of python files, whenever done that, we could not use the import of python packages.