-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#125] Ensuring objects are deleted properly #300
base: master
Are you sure you want to change the base?
[#125] Ensuring objects are deleted properly #300
Conversation
template <class AnswerType> | ||
QueryNodeServer<AnswerType>::~QueryNodeServer() { | ||
this->graceful_shutdown(); | ||
if (this->query_answer_processor != NULL) { | ||
this->query_answer_processor->join(); | ||
delete this->query_answer_processor; | ||
this->query_answer_processor = NULL; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be removed because the base class destructor is already doing the same.
template <class AnswerType> | ||
QueryNodeClient<AnswerType>::~QueryNodeClient() { | ||
this->graceful_shutdown(); | ||
if (this->query_answer_processor != NULL) { | ||
this->query_answer_processor->join(); | ||
delete this->query_answer_processor; | ||
this->query_answer_processor = NULL; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be removed because the base class destructor is already doing the same.
test.metta.gz
Steps to run:
test.metta.gz
file (usedas-cli
for that).make build-all
make run-attention-broker
make run-query-agent
Expected output (in this example, QA allocated ~311MB):
