Skip to content

Introducing version_naming property that makes modulefile as version … #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vsoch merged 12 commits into from
Jan 11, 2025
Merged

Introducing version_naming property that makes modulefile as version … #679

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
53e085f
Introducing version_naming property that makes modulefile as version …
AmjadUEA Jan 1, 2025
e1996fa
Ran black to format the indenting
AmjadUEA Jan 1, 2025
5d60af3
Adding version_naming test
AmjadUEA Jan 5, 2025
2199f20
Trying to fix the test issue
AmjadUEA Jan 5, 2025
75240b5
Fixing condition for Test
AmjadUEA Jan 5, 2025
4133ee7
Adding in get statement instead of set statement
AmjadUEA Jan 6, 2025
9483d2b
Fixing line 46 replacing set with get
AmjadUEA Jan 6, 2025
5e0b994
Adding in pytest.mark.parametize for disable install testing
AmjadUEA Jan 7, 2025
6a47294
Adding in suggestions from PR review
AmjadUEA Jan 9, 2025
cc4be9b
removing the private class variable forgot to cleanup
AmjadUEA Jan 11, 2025
a929ac0
Merge branch 'main' into main
Amjadhpc Jan 11, 2025
52ae600
Bump to 0.1.31
Amjadhpc Jan 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions shpc/tests/test_version_naming.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def test_version_naming_install(tmp_path, module_sys, module_file, container_tec
client = init_client(str(tmp_path), module_sys, container_tech)

client.settings.set("version_naming", True)
assert client.settings.set("version_naming", True) is True
assert client.settings.set("version_naming") == True
# Install known tag
client.install("python:3.9.2-alpine")

Expand All @@ -69,7 +69,7 @@ def test_disabled_version_naming_install(
client = init_client(str(tmp_path), module_sys, container_tech)

client.settings.set("version_naming", False)
assert client.settings.set("version_naming", False) is False
assert client.settings.set("version_naming") == False
Copy link
Member

@vsoch vsoch Jan 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to first set it, and then use get to check the setting is what you set it to.

# Install known tag
client.install("python:3.9.2-alpine")

Expand Down