Skip to content

Need to modify the main wrapper script too ! #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 12, 2025

Conversation

muffato
Copy link
Contributor

@muffato muffato commented Apr 11, 2025

Sorry @vsoch but in #689 I forgot to update the most important of all scripts !

@vsoch
Copy link
Member

vsoch commented Apr 11, 2025

No worries! Can you bump this one more to 0.1.32? Turns out 0.1.31 was already on pypi so your previous change hasn't been released yet. The silver lining here is we can do that easily now.

@muffato muffato force-pushed the singularity_path_in_wrapper branch from 28fb879 to 2028b0b Compare April 11, 2025 23:56
@muffato
Copy link
Contributor Author

muffato commented Apr 11, 2025

Ah right, I remember 0.1.31 was released and then reverted. Since it remains on Pypi, I thought we should document it somewhere. Take a look at how I put it back in the Changelog and introduced 0.1.32

Copy link
Member

@vsoch vsoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that looks perfect. Let's merge and deploy this one - for realsies this time 😉

Thanks for both the feature and the fix!

@vsoch vsoch merged commit 5093385 into singularityhub:main Apr 12, 2025
10 checks passed
@muffato muffato deleted the singularity_path_in_wrapper branch April 12, 2025 00:40
@muffato
Copy link
Contributor Author

muffato commented Apr 12, 2025

Thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants