Skip to content

Release v0.17.0#438

Merged
sintaxi merged 12 commits intomasterfrom
release-v0.17.0
Apr 20, 2015
Merged

Release v0.17.0#438
sintaxi merged 12 commits intomasterfrom
release-v0.17.0

Conversation

@kennethormandy
Copy link
Collaborator

Merge release-v0.16.0 first.

  • Updates Terraform, thanks @sintaxi! (CoffeeScript, LESS, Jade, and Sass are all updated)
  • Adds tests for not compiling .git and www/, thanks @edrex
  • Updates fs-extra and envy-json

I tried to get #312 in but I think we might want to approach it more like npm: a .harpignore file works, config in the harp.json works, or just do nothing and we’ll give you reasonable defaults (namely, no compiling node_modules or bower_components). Shelved that for now though.

Here’s the draft blog post for the updates, if someone wants to jump in and help me finish it. ;)

sintaxi added a commit that referenced this pull request Apr 20, 2015
@sintaxi sintaxi merged commit 04996d8 into master Apr 20, 2015
@howardroark
Copy link

In regards to adding more defaults I think node_modules would be a decent start. I don't think bower_components is a good idea. What I would LOVE is for bower_components to just be copied. Most bower repos already have a subset of files which are pre-compiled for use. I have had many bower projects cause harp to fall over when compiling, but I want their files in the final product.

With that said I strongly think Harp needs to be able to specify for some files to be copied and for some to be ignored.

Since you already have a config file for Harp I see no reason why you should not just add more properties in that file which define which files these conditions should apply to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants