Conversation
Added shortening of titles based on OED abbreviations Added ellispsis-based truncation Truncation currently removes ability to break text at word boundaries (haven't found a way to resolve this).
Can now specify abbreviations that won't be abbreviated by a '.' No longer using line-clamp Fixed ascender text peaking in classes w/ >4 lines
Shortened titles now only appear when the longer title would be truncated Uses modified version of vue-line-clamp based on https://github.com/AndyDyer/vue-line-clamp/tree/add-options-change-fallback-logic
|
Fixes #401 |
src/utils/abbreviations.js
Outdated
| 'management': 'managem', | ||
| 'studies': 'stud', | ||
| 'biology': 'bio', | ||
| 'analysis': 'anal', |
There was a problem hiding this comment.
probably don't want this one
src/utils/abbreviations.js
Outdated
| 'advanced': 'adv', | ||
| 'research': 'res', | ||
| 'technology': 'tech', | ||
| 'management': 'managem', |
There was a problem hiding this comment.
maybe mgmt even? not sure how standard that is
| 'and': nonAbbreviator + '&', | ||
| 'i': nonAbbreviator + '1', | ||
| 'ii': nonAbbreviator + '2', | ||
| 'iii': nonAbbreviator + '3', | ||
| 'iv': nonAbbreviator + '4', | ||
| 'v': nonAbbreviator + '5', | ||
| 'vi': nonAbbreviator + '6', |
There was a problem hiding this comment.
what's this nonabbreviator thing? does that mean v will become |5?
| 'certificate': 'certif', | ||
| 'exercise': 'exerc', | ||
| 'physiological': 'physiol', | ||
| 'company': 'comp' |
There was a problem hiding this comment.
could be confused with computer
Changed/removed some abbreviations Fixed linter errors in vue-line-clamp.js
…into shortened-titles
georgiashay
left a comment
georgiashay
left a comment
There was a problem hiding this comment.
Looks good overall! Just some small changes in the comments. One other thing to consider is that maybe some people would want to turn this off. We don't necessarily need to add this now, but would it be easy to make this a setting in the future?
|
It may be a good idea to use the standard abbreviations for transcripts given by the Registrar's Office. |
miriam-rittenberg
force-pushed
the
shortened-titles
branch
from
0f59bcf to
eb71773
Compare
6 participants
nonAbbreviatorto an abbreviation to have it not followed by a'.'in shortened titlesSet the
Classcomponent'suseShortenedTitletotruein order to have all classes display shortened titles, even if they aren't truncatedI don't have the full list of words in class names that are missing abbreviations because my MacBook's battery died. When I get access to the files again, I will post them.