Skip to content

added scroll to the Name column of the ClassTable #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ShivaniNR
Copy link
Contributor

Currently, a scroll bar has been added to the cells of the 'Name' column, as reported for scroll or wrap by @dtemkin1 in #146. Please have a look. I am ready to make any adjustments if needed!

Referring to: #146 issue.

Copy link
Collaborator

@dtemkin1 dtemkin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for the PR! Would it be possible to add a minimum width to the class name column? On really small screens, it seems like it's just getting shrunk to the point of not being able to see anything. Also, what are thoughts on adding a horizontal scroll bar to the class links section towards the bottom?

@ShivaniNR
Copy link
Contributor Author

Hi @dtemkin1,
Thanks for the feedback!

To address the clipping issue on smaller screens, I added the overflow property directly to the cells in the 'Name' column, this helps ensure the class names remain visible across screen sizes.

As for the idea of adding a horizontal scroll bar to the class links section at the bottom, that’s a great suggestion! I’ll need to look into how feasible it is with the current AgGridReact setup, but I’ll definitely explore it.

Also, regarding setting a minimum width for the class name column, do you have a preferred value in mind that you think would work well across devices?

@ShivaniNR
Copy link
Contributor Author

Hi @dtemkin1,
Just following up to see if you had a chance to review my previous comment.

Regarding the suggestion to add a horizontal scroll bar to the class links section at the bottom, I’ve been exploring it, and I believe that adding a scrollbar to just one column may not provide the best visual experience. Instead, we might need to apply horizontal scrolling to the entire AgGrid to maintain consistency. However, since the AgGridReact component has quite restrictive styling, I’d love to hear your thoughts on this approach before proceeding further.

Thanks again for your feedback!

@dtemkin1
Copy link
Collaborator

dtemkin1 commented May 1, 2025

Ah thanks for the bump! I can take a look into how styling AgGridReact works and what we can do, and hopefully there's something that works across the board. We might have to change column properties, do you have any thoughts @psvenk?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants