Skip to content

fix: close remaining CodeQL code scanning alerts#31

Merged
adubovikov merged 1 commit into
mainfrom
fix/code-scanning-remaining
Jun 5, 2026
Merged

fix: close remaining CodeQL code scanning alerts#31
adubovikov merged 1 commit into
mainfrom
fix/code-scanning-remaining

Conversation

@adubovikov

Copy link
Copy Markdown
Member

Summary

After #30 merged, 5 alerts remained on code scanning:

  • go/path-injection in uistore/store.go (MkdirAll, Rename) and layout.go (JobArtifactDir)
  • go/weak-sensitive-data-hashing in auth.go (SIP Digest MD5/SHA-256 sinks)

This PR routes the remaining file operations through safepath.EnsureDirUnder / RenameUnder / EnsureJobArtifactsDir and moves // codeql[...] comments to the hash sink lines.

Test plan

Route uistore atomic writes and job artifact dirs through safepath helpers,
and place CodeQL suppressions on the SIP Digest hash sink lines.
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Alexandr Dubovikov seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@adubovikov adubovikov merged commit 07b7b59 into main Jun 5, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants