docker: use /app as working directory to allow running as non-root user#590
Open
fredericve wants to merge 2 commits into
Open
docker: use /app as working directory to allow running as non-root user#590fredericve wants to merge 2 commits into
fredericve wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the container build so heplify-server is installed under /app instead of /root, enabling the image to run correctly when the container is started as a non-root user.
Changes:
- Switch the runtime
WORKDIRfrom/root/to/app/in both Docker build variants. - Normalize the multi-stage build alias syntax to
AS builder.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
docker/Dockerfile |
Moves runtime working directory to /app/ so non-root users can execute the copied binary. |
docker/dockerfile-arm |
Same /app/ working directory adjustment for the ARM build variant. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The title says it all. When running heplify-server in container that does not run as root, heplify-server cannot run because the binary lives in
/root/. This fixes that by installing everything in /app