Allow configurable default admin and support user passwords. Also allow a different hostname for provisioning#624
Merged
Conversation
fredericve
changed the title
Contributor
Author
|
@lmangani Will you have any spare time soon to review this one? |
lmangani
reviewed
Mar 3, 2026
… purposes. When a pgbouncer is in front of the database it does not allow to connect as a superuser by default.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates database provisioning so Docker deployments can use a separate provisioning host and configure the seeded admin/support password, while also adjusting database creation for environments like AWS RDS.
Changes:
- Adds
DB_PROVISIONING_HOSTfor provisioning commands. - Adds
PROVISIONED_USERS_PASSand passes it to-force-password. - Splits database creation and ownership assignment into separate SQL statements.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
migration/migration.go |
Creates the database first, then alters ownership afterward. |
docker/docker-entrypoint.d/9 |
Adds provisioning host/password environment handling and wires them into provisioning commands. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Member
|
thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for having another default provisioned user password for the admin and support users.
It also adds support to have a different hostname for postgres database provisioning. This is useful when a pgbouncer is in front of the postgres database which does not allow connecting as a superuser role by default. You can then bypass the pgbouncer by connecting to the database directly.