fix(decoder): sanitize HEP timestamps for RTPengine (#909) - #911
Merged
Conversation
Clamp invalid usec, convert NTP-as-Unix headers, and fall back to receive time when Tsec is out of range so proto-5 date= partitions cannot explode the catalog (fixes #909). Bump version to 11.0.306.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tsec/Tmsecafter decode: clamp usec ≥1e6, NTP→Unix heuristic (−2208988800), fall back to receive time outside[now−10y, now+24h], and keepTimestamp/Tsec/Tmsecin sync.hep.Timestampsohep_proto_5_defaultdate=partitions no longer land in 2032–2106 from bad RTPengine HEP headers (#909).Test plan
go test ./decoder/(table-driven cases from RTPengine date issue #909)go vet ./decoder/ ./storage/ducklake/0x0009and confirmdate=is today (not 2096)Tsec/Tmsecwrites today’s partition (not1970-01-01)date=*underhep_proto_5_defaultstill need manual cleanupFixes #909