refactor(flex): apply vanilla-extract #163

jiji-hoon96 · 2025-05-21T08:54:34Z

Changes

vanilla extract 적용
flex 옵션 추가

Visuals

Checklist

Have you written the functional specifications?
Have you written the test code?

Additional Discussion Points

- CSS 클래스로 변환 - 스토리북에 grow, shrink, basis 추가 - 일부 동적요소 대응하도록 수정

changeset-bot · 2025-05-21T08:54:37Z

⚠️ No Changeset found

Latest commit: 12bea31

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2025-05-21T08:54:39Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

- build 버그 수정

codecov · 2025-05-21T08:58:37Z

Codecov Report

Attention: Patch coverage is 70.00000% with 12 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
packages/flex/src/constants/index.ts	0.00%	11 Missing and 1 partial ⚠️

Files with missing lines	Coverage Δ
packages/flex/src/Flex.css.ts	`100.00% <100.00%> (ø)`
packages/flex/src/Flex.tsx	`100.00% <100.00%> (ø)`
packages/flex/src/constants/index.ts	`0.00% <0.00%> (ø)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

packages/flex/src/Flex.tsx

froggy1014 · 2025-05-23T04:49:04Z

packages/flex/src/Flex.tsx

+    align && styles.align[align],
+    justify && styles.justify[justify],
+    wrap && styles.wrap[wrap],
+    inline && styles.display['inline-flex'],


styles.base에 display:flex가 default 값이고, inline flag가 세워지면 inline-flex로 오버라이딩이 되는 방식인 것 같은데, 그 의도를 파악하기 어려웠달까요.

inline ? styles.display['inline-flex'] : styles.display['flex']

or

inline ? styles.display['inline-flex'] : styles.base

이런식으로 하는건 어떤가효...? styles.base가 아직 display: flex만 잡고있기에 가능하긴 합니다만.

흠.. 그럴 수 있겠네
그럼 base 를 조건부 거는게 아니라 inline 조건부 걸어서 CSS 오버라이드에 의존하지 않도록 해야겠다!

Co-authored-by: Evan <[email protected]>

- 명시적 조건부 렌더링 추가

froggy1014 · 2025-05-23T13:58:59Z

packages/flex/src/Flex.tsx

+  direction?: 'row' | 'column' | 'row-reverse' | 'column-reverse';
+  align?: 'flex-start' | 'flex-end' | 'center' | 'stretch' | 'baseline' | 'normal';
+  justify?: 'flex-start' | 'flex-end' | 'center' | 'space-between' | 'space-around' | 'space-evenly' | 'normal';
+  wrap?: 'nowrap' | 'wrap' | 'wrap-reverse';


Flex.css.ts에서 정의된 variant를 여기서 다시 한번 하드코딩으로 집어 넣게되면, 나중에 변경되었을때 유지보수가 힘들 것 같은데, Flex variant를 같이 공유해서 타입을 잡을 수는 없을까요 ?

오케!
상수 파일에서 통합관리 하도록 분리했어! 땡큐

- 코드 리뷰 반영 - constants 로 상수값 관리 - lint 버그 수정

jiji-hoon96 added 2 commits May 21, 2025 14:48

refactor(flex): migrate to Vanilla Extract

1cd4255

refactor(flex): migrate to Vanilla Extract

67b0d70

- CSS 클래스로 변환 - 스토리북에 grow, shrink, basis 추가 - 일부 동적요소 대응하도록 수정

jiji-hoon96 requested review from noahluftyang, froggy1014, synuns, dev-hobin, leejiwonn and haedawn as code owners May 21, 2025 08:54

auto-assign bot assigned jiji-hoon96 May 21, 2025

refactor(flex): migrate to Vanilla Extract

9649d25

- build 버그 수정

froggy1014 reviewed May 23, 2025

View reviewed changes

jiji-hoon96 and others added 2 commits May 23, 2025 15:21

Update packages/flex/src/Flex.tsx

022f19e

Co-authored-by: Evan <[email protected]>

fix(flex): migrate to Vanilla Extract

2300765

- 명시적 조건부 렌더링 추가

froggy1014 reviewed May 23, 2025

View reviewed changes

fix(flex): migrate to Vanilla Extract

12bea31

- 코드 리뷰 반영 - constants 로 상수값 관리 - lint 버그 수정

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor(flex): apply vanilla-extract #163

refactor(flex): apply vanilla-extract #163

Uh oh!

jiji-hoon96 commented May 21, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented May 21, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented May 21, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

codecov bot commented May 21, 2025 •

edited

Loading

Uh oh!

Uh oh!

froggy1014 May 23, 2025 •

edited

Loading

Uh oh!

jiji-hoon96 May 23, 2025

Uh oh!

froggy1014 May 23, 2025

Uh oh!

jiji-hoon96 May 24, 2025

Uh oh!

Uh oh!

refactor(flex): apply vanilla-extract #163

Are you sure you want to change the base?

refactor(flex): apply vanilla-extract #163

Uh oh!

Conversation

jiji-hoon96 commented May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Visuals

Checklist

Additional Discussion Points

Uh oh!

changeset-bot bot commented May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented May 21, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

codecov bot commented May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

froggy1014 May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jiji-hoon96 May 23, 2025

Choose a reason for hiding this comment

Uh oh!

froggy1014 May 23, 2025

Choose a reason for hiding this comment

Uh oh!

jiji-hoon96 May 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jiji-hoon96 commented May 21, 2025 •

edited

Loading

changeset-bot bot commented May 21, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented May 21, 2025 •

edited

Loading

froggy1014 May 23, 2025 •

edited

Loading