refactor(divider): apply vanilla-extract #164

jiji-hoon96 · 2025-05-21T08:55:42Z

Changes

vanilla extract 추가
색상 옵션 추가
스토리북 섹션 분리

Visuals

Checklist

Have you written the functional specifications?
Have you written the test code?

Additional Discussion Points

- test 조건 추가 - vanilla-extract recipe 활용해 스타일 확장 - 필요한 패키지 추가

- divider 스토리북에 색상 섹션 추가 - 사용자 스타일링 UI 추가

changeset-bot · 2025-05-21T08:55:46Z

⚠️ No Changeset found

Latest commit: e2d7a08

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2025-05-21T08:55:48Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2025-05-21T08:56:47Z

Codecov Report

Attention: Patch coverage is 92.85714% with 2 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
packages/divider/src/constants/index.ts	0.00%	1 Missing and 1 partial ⚠️

Files with missing lines	Coverage Δ
packages/divider/src/Divider.css.ts	`100.00% <100.00%> (ø)`
packages/divider/src/Divider.test.tsx	`100.00% <100.00%> (ø)`
packages/divider/src/Divider.tsx	`100.00% <100.00%> (ø)`
packages/divider/src/constants/index.ts	`0.00% <0.00%> (ø)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

noahluftyang · 2025-05-23T13:31:13Z

packages/divider/src/Divider.css.ts

+
+export type Orientation = keyof typeof Orientation;
+
+export const divider = recipe({


divider도 recipe 없이 구현해도 복잡하지 않을 것 같아!

noahluftyang · 2025-05-23T13:32:12Z

packages/divider/src/Divider.tsx

-  orientation?: 'horizontal' | 'vertical';
+export interface DividerProps extends ComponentProps<'hr'> {
+  orientation?: styles.Orientation;
+  color?: 'default' | 'primary' | 'dark';


color도 Orientation처럼 const 객체로 분리해주면 어떨까?

- 코드 리뷰 반영 - vanilla extract recipe 제거 - 상수 분리

- pnpm install --no-frozen-lockfile

jiji-hoon96 added 3 commits May 21, 2025 11:47

refactor(divider): migrate to Vanilla Extract

4124ff5

refactor(divider): migrate to Vanilla Extract

b45167e

- test 조건 추가 - vanilla-extract recipe 활용해 스타일 확장 - 필요한 패키지 추가

refactor(divider): migrate to Vanilla Extract

558811d

- divider 스토리북에 색상 섹션 추가 - 사용자 스타일링 UI 추가

jiji-hoon96 requested review from noahluftyang, froggy1014, synuns, dev-hobin, leejiwonn and haedawn as code owners May 21, 2025 08:55

auto-assign bot assigned jiji-hoon96 May 21, 2025

noahluftyang reviewed May 23, 2025

View reviewed changes

jiji-hoon96 added 2 commits May 24, 2025 12:19

fix(divider): migrate to Vanilla Extract

6dff1ef

- 코드 리뷰 반영 - vanilla extract recipe 제거 - 상수 분리

fix(divider): migrate to Vanilla Extract

e2d7a08

- pnpm install --no-frozen-lockfile

noahluftyang approved these changes May 24, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor(divider): apply vanilla-extract #164

refactor(divider): apply vanilla-extract #164

Uh oh!

jiji-hoon96 commented May 21, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented May 21, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented May 21, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

codecov bot commented May 21, 2025 •

edited

Loading

Uh oh!

noahluftyang May 23, 2025

Uh oh!

noahluftyang May 23, 2025

Uh oh!

Uh oh!


		export type Orientation = keyof typeof Orientation;

		export const divider = recipe({

refactor(divider): apply vanilla-extract #164

Are you sure you want to change the base?

refactor(divider): apply vanilla-extract #164

Uh oh!

Conversation

jiji-hoon96 commented May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Visuals

Checklist

Additional Discussion Points

Uh oh!

changeset-bot bot commented May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented May 21, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

codecov bot commented May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

noahluftyang May 23, 2025

Choose a reason for hiding this comment

Uh oh!

noahluftyang May 23, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jiji-hoon96 commented May 21, 2025 •

edited

Loading

changeset-bot bot commented May 21, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented May 21, 2025 •

edited

Loading