Skip to content

refactor(skeleton): apply vanilla-extract #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: release/v1
Choose a base branch
from
Open

refactor(skeleton): apply vanilla-extract #165

wants to merge 5 commits into from

Conversation

jiji-hoon96
Copy link
Member

Changes

  • vanilla-extract 변경
  • 새로운 variant, props 추가
  • 메인 로직 수정
  • 스토리북, 테스트코드 수정

Visuals

Checklist

  • Have you written the functional specifications?
  • Have you written the test code?

Additional Discussion Points

FIXME 에 작성한거처럼 디자인 수정해야할것같아요.
X-lay 같음ㅋ쿠

@jiji-hoon96
refactor(skeleton): migrate to Vanilla Extract
f53651b 
- vanilla-extract 설정 추가
- side dependencies 추가
@jiji-hoon96
refactor(skeleton): migrate to Vanilla Extract
9a52892 
- CSS 모듈에서 vanilla-extract recipe 패턴으로 마이그레이션
- 새로운 variant 추가: text(텍스트용), rounded(둥근 모서리)
- 새로운 props 추가: lines(여러 줄 텍스트), pulse(빠른 애니메이션), shimmer(쉬머 효과)
- @sipe-team/tokens 패키지 활용
- aria-busy, aria-label 속성으로 접근성 개선
@jiji-hoon96
refactor(skeleton): migrate to Vanilla Extract
bedd8d4 
- 스토리북 예제 추가
- 테스트 커버리지 확장
- width/height props에서 문자열과 숫자 값 지원
@jiji-hoon96
refactor(skeleton): migrate to Vanilla Extract
8e48286 
- em, rem => px 단위로 테스트 하도록 수정
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 22, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: a737ae2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented May 22, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov Codecov
Copy link

codecov bot commented May 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
packages/skeleton/src/Skeleton.css.ts 100.00% <100.00%> (ø)
packages/skeleton/src/Skeleton.test.tsx 100.00% <100.00%> (ø)
packages/skeleton/src/Skeleton.tsx 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jiji-hoon96
fix(skeleton): migrate to Vanilla Extract
a737ae2 
- type check 에러 디버깅
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noahluftyang noahluftyang Awaiting requested review from noahluftyang noahluftyang is a code owner

@froggy1014 froggy1014 Awaiting requested review from froggy1014 froggy1014 is a code owner

@synuns synuns Awaiting requested review from synuns synuns is a code owner

@dev-hobin dev-hobin Awaiting requested review from dev-hobin dev-hobin is a code owner

@leejiwonn leejiwonn Awaiting requested review from leejiwonn leejiwonn is a code owner

@haedawn haedawn Awaiting requested review from haedawn haedawn is a code owner

Assignees

@jiji-hoon96 jiji-hoon96

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jiji-hoon96