Skip to content

Conversation

@froggy1014
Copy link
Contributor

@froggy1014 froggy1014 commented Aug 21, 2025

Changes

전 기수분들 전부 리뷰어 할당하는거 지울게요 ~

Summary by CodeRabbit

  • Chores
    • CODEOWNERS 업데이트로 일부 소유자 제거 및 신규 소유자 추가, 기존 소유자 일부 유지
    • 코드 리뷰 책임자 범위 조정에 따른 리포지토리 관리 개선
    • 애플리케이션 기능, UI, 성능에는 변화 없음 (런타임 영향 없음)

@changeset-bot
Copy link

changeset-bot bot commented Aug 21, 2025

⚠️ No Changeset found

Latest commit: 759c663

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Aug 21, 2025

Deploy Preview for side-design-system ready!

Name Link
🔨 Latest commit 759c663
🔍 Latest deploy log https://app.netlify.com/projects/side-design-system/deploys/68a6eadeeb32ce00089c89a2
😎 Deploy Preview https://deploy-preview-199--side-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link

coderabbitai bot commented Aug 21, 2025

Walkthrough

.gitHub/CODEOWNERS의 소유자 목록이 갱신되어 일부 계정이 제거되고 신규 계정이 추가되었습니다. 코드나 런타임 동작 변경은 없습니다.

Changes

Cohort / File(s) Summary
CODEOWNERS 업데이트
.github/CODEOWNERS
소유자 목록 갱신: 제거 — hy57in, developerjhp, bae-sh, yeojini, SEMIN-97, heeji289; 추가 — haedawn; 유지 — kimdaeyeobbb, noahluftyang, froggy1014, synuns, jiji-hoon96. 리뷰 소유 범위만 변경.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

documentation

Suggested reviewers

  • kimdaeyeobbb
  • noahluftyang
  • synuns

Poem

토끼가 깃숲을 살금살금 뛰네 🐇
이름표 갈아 끼우고, 줄 맞춰 보며—
“이 코드 누가 지킬까?” 귀를 쫑긋!
오래된 발자국 지우고, 새 발자국 남기고,
리뷰의 달빛 아래 체크리스트 톡톡.

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ci/remove-reviewer

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@froggy1014 froggy1014 enabled auto-merge (squash) August 21, 2025 09:46
@codecov
Copy link

codecov bot commented Aug 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
.github/CODEOWNERS (2)

1-1: 유지보수성 향상을 위해 개인 계정 대신(또는 함께) 팀 핸들(@org/team) 사용 검토

개인 계정 기반은 변동(퇴사/휴면)에 취약합니다. 조직 팀을 사용하면 관리 비용을 줄이고 지속성을 확보할 수 있습니다.

예시 1) 팀으로 대체:

-*   @kimdaeyeobbb @noahluftyang @froggy1014 @synuns @jiji-hoon96 @haedawn
+*   @your-org/reviewers

예시 2) 팀을 우선으로, 개인은 백업:

-*   @kimdaeyeobbb @noahluftyang @froggy1014 @synuns @jiji-hoon96 @haedawn
+*   @your-org/reviewers @kimdaeyeobbb @noahluftyang @froggy1014 @synuns @jiji-hoon96 @haedawn

원하시면 실제 조직/팀 핸들에 맞춘 최종 라인을 제안드리겠습니다.


1-1: 변경 이력 주석(메타데이터) 추가 제안

후속 추적을 위해 변경 이유/시점을 주석으로 남기면 좋습니다. 필수는 아니지만 향후 감사/회고에 유용합니다.

+# 기본 코드 오너 (2025-08-21): 비활성 리뷰어 제거, @haedawn 추가
 *   @kimdaeyeobbb @noahluftyang @froggy1014 @synuns @jiji-hoon96 @haedawn
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between e32225d and 759c663.

📒 Files selected for processing (1)
  • .github/CODEOWNERS (1 hunks)
🔇 Additional comments (3)
.github/CODEOWNERS (3)

1-1: PR 의도 부합: 비활성 리뷰어 제거 및 기본 CODEOWNERS 정리 완료

리뷰어 풀을 슬림화하려는 목적과 일치하며, 런타임/빌드 영향은 없습니다. 기본 경로 *에 대해 현재 활성 멤버만 남겨 깔끔합니다.


1-1: 브랜치 보호 및 CODEOWNERS 리뷰 요구 설정 확인 요청

현재 제공된 스크립트는 로컬에 Git 리포지토리 정보가 없어서 자동 실행이 불가능합니다. 다음 수정된 명령어를 GitHub CLI가 올바르게 동작하는 환경(로컬 터미널 또는 CI)에서 직접 실행해 주세요.

#!/bin/bash
set -euo pipefail

# owner/repo 형태로 리포지토리명을 직접 지정
REPO="your-org/your-repo"
# 기본 브랜치명을 직접 지정 (예: main, master)
DEFAULT_BRANCH="main"

echo "[브랜치 보호] require_code_owner_reviews 설정 확인"
gh api -H "Accept: application/vnd.github+json" \
  "/repos/$REPO/branches/$DEFAULT_BRANCH/protection" \
  | jq '.required_pull_request_reviews.require_code_owner_reviews'

echo
echo "[CODEOWNERS] 지정된 오너들의 권한 확인"
gh api -H "Accept: application/vnd.github+json" \
  "/repos/$REPO/contents/.github/CODEOWNERS" \
  | jq -r '.content' | base64 --decode \
  | awk 'NF && $1=="*" {for(i=2;i<=NF;i++) print $i}' \
  | tr -d '@' \
  | while read -r user; do
      perm=$(gh api -H "Accept: application/vnd.github+json" \
        "/repos/$REPO/collaborators/$user/permission" \
        -q .permission 2>/dev/null || echo "none")
      echo "$user: ${perm:-not a collaborator}"
    done

위 스크립트를 실행한 후 출력 결과를 공유해 주시면, 설정이 올바르게 적용되었는지 확인하고 다음 절차를 안내드리겠습니다.


1-1: 중복 CODEOWNERS 및 규칙 충돌 점검 완료 — 추가 조치 불필요

  • fd -HI --glob CODEOWNERS 결과: 리포지토리에 .github/CODEOWNERS 파일 하나만 존재 (중복 없음)
  • 상위 50줄 확인 결과: 단일 매칭 규칙(* @kimdaeyeobbb @noahluftyang @froggy1014 @synuns @jiji-hoon96 @haedawn)만 정의되어 있어 충돌 우려 없음

@froggy1014 froggy1014 merged commit 08a2880 into main Aug 21, 2025
8 checks passed
@froggy1014 froggy1014 deleted the ci/remove-reviewer branch August 21, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants