-
Notifications
You must be signed in to change notification settings - Fork 4
refactor(theme): Use assignInlineVars for theme variable binding #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/v1
Are you sure you want to change the base?
Conversation
|
✅ Deploy Preview for side-design-system ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Changes
ThemeProvider에서DOM 조작 방식을 선언형 contract 시스템으로 변경했습니다.
@vanilla-extract/dynamic의assignInlineVars를 사용하여 Vanilla Extract의 contract 시스템을 그대로 쓸 수 있게됩니다.--side-color-primary)이 contract 정의와 일치하지 않음