fix(spawn): clear ForUser in sub-turn ToolResult to prevent duplicate messages#3142
Open
jincheng-xydt wants to merge 1 commit into
Open
fix(spawn): clear ForUser in sub-turn ToolResult to prevent duplicate messages#3142jincheng-xydt wants to merge 1 commit into
jincheng-xydt wants to merge 1 commit into
Conversation
… messages When a spawn sub-agent completes, the ToolResult's ForUser field was set to the same content as ForLLM, triggering two independent push paths: 1) The async callback directly pushed to the outbound bus 2) The main agent's orchestration path also delivered the result Clear ForUser so the main agent exclusively controls message delivery, eliminating duplicate messages on async sub-agent completion. Closes sipeed#3094
Contributor
Author
|
CLA has been signed. Please verify. |
This was referenced Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Clear the
ForUserfield in the spawn sub-turnToolResultto prevent duplicate message delivery on async sub-agent completion.Root cause: When a spawn sub-agent finishes,
subturn.goset bothForLLMandForUserto the same content. This triggered two independent push paths:pipeline_execute.godirectly pushed to the outbound bus whenForUserwas non-emptypendingResultsFix: Clear
ForUser(set to"") so the main agent exclusively controls message delivery, eliminating the duplicate.🗣️ Type of Change
🤖 AI Code Generation
🔗 Related Issue
Closes #3094
📚 Technical Context (Skip for Docs)
🧪 Test Environment
☑️ Checklist