Skip to content

pause/resume waveOut option defaults to old behaviour #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

pause/resume waveOut option defaults to old behaviour #11

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
76379f5
pause/resume waveOut option defaults to old behaviour
finebytes Jun 16, 2023
3f53f4d
remove optional parameter as it's not part of external interface
finebytes Jun 16, 2023
21abfa1
stop buffering when audio paused
finebytes Jun 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/WindowsAudioEndPoint.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,13 +229,15 @@ public Task PauseAudio()
{
_isPaused = true;
_waveInEvent?.StopRecording();
_waveOutEvent?.Stop();
return Task.CompletedTask;
}

public Task ResumeAudio()
{
_isPaused = false;
_waveInEvent?.StartRecording();
_waveOutEvent?.Play();
return Task.CompletedTask;
}

Expand Down Expand Up @@ -286,15 +288,15 @@ private void LocalAudioSampleAvailable(object sender, WaveInEventArgs args)
/// <param name="pcmSample">Raw PCM sample from remote party.</param>
public void GotAudioSample(byte[] pcmSample)
{
if (_waveProvider != null)
if (_waveProvider != null && !_isPaused)
{
_waveProvider.AddSamples(pcmSample, 0, pcmSample.Length);
}
}

public void GotAudioRtp(IPEndPoint remoteEndPoint, uint ssrc, uint seqnum, uint timestamp, int payloadID, bool marker, byte[] payload)
{
if (_waveProvider != null && _audioEncoder != null)
if (_waveProvider != null && _audioEncoder != null && !_isPaused)
{
var pcmSample = _audioEncoder.DecodeAudio(payload, _audioFormatManager.SelectedFormat);
byte[] pcmBytes = pcmSample.SelectMany(x => BitConverter.GetBytes(x)).ToArray();
Expand Down