Fix SIPParameters.ToString() #1470
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. Conceptually it looks fine (ConcurrentDictionary was not available when that class was written). It is causing 7 failing unit tests though and those will need to be fixed before the PR can be merged. 
|
| public void RemoveAll() | ||
| { | ||
| m_dictionary = new Dictionary<string, string>(); | ||
| m_dictionary = new ConcurrentDictionary<string, string>(); |
There was a problem hiding this comment.
Instead of instantiating a new instance keep the existing one and clear it:
Suggested change
| m_dictionary = new ConcurrentDictionary<string, string>(); | |
| m_dictionary.Clear(); |
| SIPParameters copy = new SIPParameters(); | ||
| copy.TagDelimiter = this.TagDelimiter; | ||
| copy.m_dictionary = (this.m_dictionary != null) ? new Dictionary<string, string>(this.m_dictionary) : new Dictionary<string, string>(); | ||
| copy.m_dictionary = (this.m_dictionary != null) ? new ConcurrentDictionary<string, string>(this.m_dictionary) : new ConcurrentDictionary<string, string>(); |
There was a problem hiding this comment.
m_dictionary is never null:
Suggested change
| copy.m_dictionary = (this.m_dictionary != null) ? new ConcurrentDictionary<string, string>(this.m_dictionary) : new ConcurrentDictionary<string, string>(); | |
| copy.m_dictionary = (!this.m_dictionary.IsEmpty) ? new ConcurrentDictionary<string, string>(this.m_dictionary) : new ConcurrentDictionary<string, string>(); |
|
|
||
| //[DataMember] | ||
| private Dictionary<string, string> m_dictionary; | ||
| private ConcurrentDictionary<string, string> m_dictionary; |
There was a problem hiding this comment.
Given the other comments, m_dictionary can be read-only:
Suggested change
| private ConcurrentDictionary<string, string> m_dictionary; | |
| private readonly ConcurrentDictionary<string, string> m_dictionary; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a draft that worked for me but there can be other things to check