Refactor logging to use structured message templates for DTLS#1669
Merged
Conversation
Refactored logging in DtlsClient and DtlsServer to use structured message templates with argument placeholders, replacing string concatenation. Added a new Log.Debug overload and a helper for formatting templates in Log.cs. Ensured all debug logs are guarded by Log.DebugEnabled, aligning with user preferences for structured logging.
Member
|
I don't think this PR achieves its goals. There doesn't seem to be a lot of point standardising the log message templates to align with the rest of the library when the actual logging mechanism is completely different. The proper fix would seem to be making the DTLS logging use the same ILogger mechanism as the rest of the library. |
Replaced the custom Log class and all related usages with Microsoft.Extensions.Logging. Updated DtlsClient and DtlsServer to use structured logging via ILogger, including logger.IsEnabled checks for value processing. Removed Log.cs and introduced static logger instances using LogFactory.CreateLogger<T>(). All log messages now use structured templates and appropriate log levels.
Contributor
Author
|
Good point! I've converted to |
sipsorcery
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored logging in DtlsClient and DtlsServer to use structured message templates with argument placeholders, replacing string concatenation. Added a new Log.Debug overload and a helper for formatting templates in Log.cs. Ensured all debug logs are guarded by Log.DebugEnabled, aligning with user preferences for structured logging.
Split of #1639