Skip to content

fix(tests): sync EXPECTED_CHILD_SECRETS with GLITCHTIP_DSN forwards#1801

Merged
chernistry merged 1 commit into
mainfrom
fix/dispatcher-secrets-glitchtip-expectation
May 21, 2026
Merged

fix(tests): sync EXPECTED_CHILD_SECRETS with GLITCHTIP_DSN forwards#1801
chernistry merged 1 commit into
mainfrom
fix/dispatcher-secrets-glitchtip-expectation

Conversation

@chernistry

@chernistry chernistry commented May 21, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • post-ci-dispatcher.yml forwards GLITCHTIP_DSN to the auto-heal and bernstein-ci-fix children (added during the GlitchTip wiring landed in v2.6.0) so each child can emit telemetry on its own failure.
  • The matching EXPECTED_CHILD_SECRETS fixture in tests/unit/test_post_ci_dispatcher_yaml.py was not updated when those forwards landed, so test_dispatcher_calls_each_child[auto-heal] tripped on the macOS test matrix cell after recursive test discovery widened the gated set.
  • Update the two stale frozensets to match the workflow.

Test plan

  • pytest tests/unit/test_post_ci_dispatcher_yaml.py (16 passed)

Summary by CodeRabbit

  • Tests
    • Updated CI/CD workflow test assertions to reflect expanded secret forwarding: two workflows now include an additional secret for error tracking in their expected configurations.

Review Change Stack

post-ci-dispatcher.yml forwards GLITCHTIP_DSN to the auto-heal and
bernstein-ci-fix children so those workflows can emit error events when
their own runs fail. The matching test fixture in
EXPECTED_CHILD_SECRETS was not updated when the forward landed, so
test_dispatcher_calls_each_child[auto-heal] failed on the macOS test
matrix cell once recursive test discovery widened the gated set.

Update the two stale frozensets to match the workflow secrets block.
@chernistry chernistry enabled auto-merge (squash) May 21, 2026 19:15

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @chernistry, you have reached your weekly rate limit of 2500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@github-actions

Copy link
Copy Markdown
Contributor

Sonar insights (advisory, no merge-block)

Snapshot of bernstein on the configured Sonar instance:

Metric Value
Coverage 13.5
Code smells 123
Bugs 10
Vulnerabilities 2
Security hotspots 87

Run bernstein doctor sonar locally for the full surface.

This comment is a soft signal. The Sonar scan runs on push to main; the PR check itself never fails on smells.

@github-actions

Copy link
Copy Markdown
Contributor

Review-bot acknowledgement summary

  • Must-address findings: 0 (0 acknowledged, 0 open)
  • Informational findings: 0

All must-address findings are resolved or acknowledged.

@github-actions

Copy link
Copy Markdown
Contributor

bernstein doctor observe for PR #1801 (fix/dispatcher-secrets-glitchtip-expectation): ok=0, warn=2, fail=0, error=0, skipped=2

sonar -- WARN (project bernstein)

metric value delta threshold status
coverage_pct 13.5% new 80.0% fail
code_smells 123 new 50 warn
bugs 10 new 0 fail
vulnerabilities 2 new 0 warn
security_hotspots 87 new 0 fail

code-scanning -- WARN (4 open alert(s))

metric value delta threshold status
open_alerts 4 new 0 warn
critical_alerts 0 new 0 ok
high_alerts 2 new 0 warn
medium_alerts 0 new - ok
low_alerts 0 new - ok
Skipped backends (credentials not configured)
  • glitchtip: BERNSTEIN_GLITCHTIP_TOKEN not set
  • dt: DTRACK_URL/TOKEN/PROJECT not set

See docs/observability/unified-doctor.md for backend setup notes.

@chernistry chernistry merged commit 4e221e6 into main May 21, 2026
60 of 62 checks passed
@chernistry chernistry deleted the fix/dispatcher-secrets-glitchtip-expectation branch May 21, 2026 19:18
@coderabbitai

coderabbitai Bot commented May 21, 2026

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: fbb7bc8b-8400-4949-abdb-83018f2e735b

📥 Commits

Reviewing files that changed from the base of the PR and between 9bf3306 and 71e3d5d.

📒 Files selected for processing (1)
  • tests/unit/test_post_ci_dispatcher_yaml.py

📝 Walkthrough

Walkthrough

Test fixture EXPECTED_CHILD_SECRETS updated to reflect tightened dispatcher secret forwarding: auto-heal and bernstein-ci-fix now each expect GLITCHTIP_DSN alongside their existing secrets. This aligns regression assertions with changed workflow secret consumption.

Changes

Secret Forwarding Regression Test

Layer / File(s) Summary
Secret consumption test fixture
tests/unit/test_post_ci_dispatcher_yaml.py
Lines 40–43: EXPECTED_CHILD_SECRETS updated so auto-heal expects GLITCHTIP_DSN with its Telegram secrets, and bernstein-ci-fix expects GLITCHTIP_DSN with GEMINI_API_KEY.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

ci, size/s

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/dispatcher-secrets-glitchtip-expectation

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant