Skip to content

feat: add user-defined command aliases via ~/.bernstein/aliases.yaml#276

Closed
TheCodingDragon0 wants to merge 3 commits into
sipyourdrink-ltd:mainfrom
TheCodingDragon0:feat/user-aliases-clean
Closed

feat: add user-defined command aliases via ~/.bernstein/aliases.yaml#276
TheCodingDragon0 wants to merge 3 commits into
sipyourdrink-ltd:mainfrom
TheCodingDragon0:feat/user-aliases-clean

Conversation

@TheCodingDragon0

Copy link
Copy Markdown
Contributor

Resubmission of #265/#275. Fixes #249.

All Pyright errors resolved:

  • Renamed _USER_ALIASES to _user_aliases (lowercase, not treated as constant)
  • Fixed dict type narrowing in _load_user_aliases()
  • Removed unnecessary isinstance checks

Extended the alias system to support user-defined aliases loaded from ~/.bernstein/aliases.yaml. User aliases override built-in ones. The �ernstein aliases command shows whether each alias is built-in or user-defined.

@kilo-code-bot

kilo-code-bot Bot commented Apr 6, 2026

Copy link
Copy Markdown

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 files)
  • src/bernstein/cli/aliases.py

Reviewed by grok-code-fast-1 · 95,777 tokens

@sonarqubecloud

sonarqubecloud Bot commented Apr 6, 2026

Copy link
Copy Markdown

@chernistry

Copy link
Copy Markdown
Collaborator

Hey! This feature was already merged in #264 (which included both config diff and user aliases). Your code is in main — thanks for the persistence! 👍

@chernistry chernistry closed this Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add user-defined command aliases via ~/.bernstein/aliases.yaml

2 participants