Skip to content

feat: wire retro-demoscene widgets into TUI app#290

Merged
chernistry merged 2 commits into
mainfrom
feat/retro-tui-integration
Apr 6, 2026
Merged

feat: wire retro-demoscene widgets into TUI app#290
chernistry merged 2 commits into
mainfrom
feat/retro-tui-integration

Conversation

@chernistry

Copy link
Copy Markdown
Collaborator

Summary

  • Integrate 4 retro-demoscene widgets (CRT shader, plasma canvas, tracker view, oscilloscope) into the main BernsteinApp TUI
  • Add Shift+C/P/T/O keybindings for toggling each widget
  • Feed agent data from /status polling loop into visible retro widgets
  • All widgets hidden by default; toggle on demand

Test plan

  • uv run pytest tests/unit/test_app_retro_integration.py -x -q -- 2 passed
  • uv run ruff format + uv run ruff check -- clean
  • Pyright strict typecheck passes (pre-push hook)

🤖 Generated with Claude Code

chernistry and others added 2 commits April 7, 2026 00:49
Integrate CRT shader, plasma canvas, tracker view, and oscilloscope
into the main BernsteinApp with keybindings (Shift+C/P/T/O),
visibility toggles, and data flow from the /status polling loop.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Use explicit cast and typed dict construction instead of dict
comprehension over list[Any] to satisfy reportUnknownVariableType.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions

github-actions Bot commented Apr 6, 2026

Copy link
Copy Markdown
Contributor

AI Review (GitHub Models)

Summary

The pull request introduces retro-demoscene widgets (CRT shader, oscilloscope, plasma canvas, and tracker) to the Bernstein TUI application, enhancing its interactive capabilities. The changes include feature integrations, binding keys for toggling the visibility of these widgets, and corresponding updates in the data flow. Unit tests have been added to verify the functionality of the CRT shader and ensure widget importability.

Risk Assessment

Medium: While the changes introduce meaningful features, they also add complexity to the application's state management and data flow, which could lead to potential bugs or performance issues. Additionally, user experience could be impacted if the toggling of visual elements is not intuitive.

Actionable Recommendations

  • Code Clarity: Ensure that new methods related to the retro widgets are well-documented to enhance maintainability.
  • User Experience: Review the key bindings for toggling widgets to ensure they do not conflict with existing shortcuts and are intuitive to use.
  • **Performance

@kilo-code-bot

kilo-code-bot Bot commented Apr 6, 2026

Copy link
Copy Markdown

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (2 files)
  • src/bernstein/tui/app.py - Integration logic for retro widgets
  • tests/unit/test_app_retro_integration.py - Basic tests for widget integration

Reviewed by grok-code-fast-1 · 109,473 tokens

@sonarqubecloud

sonarqubecloud Bot commented Apr 6, 2026

Copy link
Copy Markdown

@chernistry chernistry merged commit 9621a4b into main Apr 6, 2026
9 checks passed
@github-actions

github-actions Bot commented Apr 6, 2026

Copy link
Copy Markdown
Contributor

CI Summary

Check Result
Repo hygiene ✅ success
Lint ✅ success
Type check ✅ success
Tests ❌ failure
Spelling ✅ success
Dead code ✅ success
Workflow lint ✅ success
Dist size ✅ success
SonarCloud ⏭️ skipped

Coverage and detailed reports are available via Codecov and the Checks tab.

chernistry added a commit that referenced this pull request Apr 6, 2026
Removes CRT shader, plasma canvas, tracker view, oscilloscope,
BBS boot sequence, retro themes, and their integration into
app.py and dashboard.py.

Reverts PRs #277, #278, #279, #281, #284, #290, #291.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@chernistry chernistry deleted the feat/retro-tui-integration branch April 8, 2026 09:48
chernistry added a commit that referenced this pull request Apr 30, 2026
* feat: wire retro-demoscene widgets into TUI app

Integrate CRT shader, plasma canvas, tracker view, and oscilloscope
into the main BernsteinApp with keybindings (Shift+C/P/T/O),
visibility toggles, and data flow from the /status polling loop.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: resolve Pyright strict type errors in retro widget data flow

Use explicit cast and typed dict construction instead of dict
comprehension over list[Any] to satisfy reportUnknownVariableType.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
chernistry added a commit that referenced this pull request Apr 30, 2026
Removes CRT shader, plasma canvas, tracker view, oscilloscope,
BBS boot sequence, retro themes, and their integration into
app.py and dashboard.py.

Reverts PRs #277, #278, #279, #281, #284, #290, #291.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant