Categorize all spawn failures into actionable failure types

[chernistry]

Categorize all spawn failures into actionable failure types

Categorize all spawn failures into actionable failure types

Description

SpawnError and RateLimitError are the only spawn exception types. Add AdapterNotInstalledError, ModelNotAvailableError, PromptTooLongError, WorktreeCreationError, PermissionDeniedError, and ResourceExhaustedError. The spawner uses the category to decide retry strategy (retry vs escalate vs fail-fast).

Role: backend
Model: sonnet

---

Generated by Bernstein — task 5c123ee1a0cf

[github-actions]

AI Review (Gemini)

Gemini review could not be generated (HTTP 503).

[github-actions]

AI Review (GitHub Models)

Summary

This pull request categorizes spawn failures into actionable types, enhancing the error-handling logic in the AgentSpawner class. It adds detailed logging for different failure conditions and implements validation of worktree isolation during setup in the WorktreeManager.

Risk Assessment

Medium
While the changes introduce robust error handling and logging, modifying error classification and control flow can introduce complexity. There is a risk of inadvertently masking underlying issues if categorization isn't comprehensive or leads to premature termination of attempts, especially if the error classification doesn't account for all potential exceptions.

Actionable Recommendations

• Test Coverage: Ensure that adequate unit tests cover all new error classifications and the behavior of the retry_strategy. Validate that various edge cases are addressed.
• Documentation: Update the related documentation to reflect the new error handling mechanisms and any custom exceptions or return types introduced.
• Review Classification Logic: Audit the classify_spawn_error function for comprehensiveness to avoid un

[github-actions]

CI Summary

Check	Result
Repo hygiene	✅ success
Lint	❌ failure
Type check	⏭️ skipped
Tests	⏭️ skipped
Spelling	✅ success
Dead code	✅ success
Workflow lint	✅ success
Dist size	✅ success
SonarCloud	⏭️ skipped

Coverage and detailed reports are available via Codecov and the Checks tab.

[kilo-code-bot]

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (2 files)

• src/bernstein/core/spawner.py - Enhanced spawn failure handling with categorized errors and fail-fast logic for non-retryable failures
• src/bernstein/core/worktree.py - Added worktree isolation validation after creation

---

_{Reviewed by grok-code-fast-1 · 132,835 tokens}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud