fix(data): correct 2026-09-01 snapshot's prs_opened count - #16
Merged
Conversation
PR #9 relabeled this snapshot's date field from 2026-09-02 to 2026-09-01 (the collect workflow ran late and the manual dispatch that recovered it was mislabeled), but never re-ran the activity queries against the corrected date -- so its activity block still reflected an early-morning (~47min into the day) 2026-09-02 query, not real 2026-09-01 data. issues_opened/closed, prs_merged/closed, and commits all happened to be 0 under both interpretations, but prs_opened was wrong: stored 0, real value 2 (PRs #1685 and #1686, both created well before this snapshot's own collected_at timestamp). Verified directly against GitHub's Search API. repo/labels fields are left as-is -- they're point-in-time gauges with no historical API, so no rerun can make them accurate for 2026-09-01 specifically; this is the same already-documented limitation as any --date backfill, not something this fix changes.
mike-wendt
commented
Sep 3, 2026
mike-wendt
left a comment
mike-wendt
left a comment
Contributor
Author
There was a problem hiding this comment.
Self-reviewed and approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Found while verifying all current snapshot data end-to-end against live GitHub API values, per your request.
8/31and9/2check out exactly against live data (issues/PRs opened/closed/merged, commits, all verified via the Search API and commit history directly).9/1had one real discrepancy:activity.prs_openedwas stored as0, but GitHub shows 2 PRs (#1685, #1686) were actually opened that day.Root cause: PR #9 relabeled this snapshot's
datefield from2026-09-02to2026-09-01(the collect workflow ran late, and the manual dispatch that recovered it was mislabeled) but never re-ran the activity queries against the corrected date. The stored0s are what an early-morning (~47 minutes into the day)2026-09-02query would show -- not real2026-09-01data. Verified this precisely: both real PRs were created at04:54and22:18 UTCon 9/1, both well before this snapshot's owncollected_at(2026-09-02T00:47:38Z), so a correctcreated:2026-09-01query would have found them.Every other activity field (
issues_opened,issues_closed,prs_merged,prs_closed,commits) happened to be0under both interpretations, so this is the only field that was actually wrong.repo/labelsfields are untouched -- they're point-in-time gauges with no historical API, so no rerun makes them accurate for2026-09-01specifically. That's the same already-documented limitation as any--datebackfill, not something this PR changes.Fix
Patched the one field directly rather than rerunning
fetch_metrics.py --date 2026-09-01-- I don't haveSIRIUS_TRAFFIC_TOKENlocally, and a full rerun would have regressed this file's currently-correct traffic data (as_of_date: 2026-08-31, real values) back to null.Test plan
python3 -c "import json; json.load(...)"confirms valid JSONuv run scripts/build_site.pyexits cleanlyprs_opened: 2verified directly againstgh api /search/issues?q=repo:sirius-db/sirius+type:pr+created:2026-09-01Verify pipeline / verifypasses on this PR🤖 Generated with Claude Code