feat(site): link top committers to their GitHub profiles - #18
Merged
Conversation
Only links entries where activity.top_committers[].is_user is true -- a commit not linked to a GitHub account falls back to a raw git author name, which isn't safe to link directly (could 404, or point at an unrelated real user whose username happens to match). fetch_metrics.py now tracks is_user per committer; build_site.py propagates it through the activity-window aggregation (defaulting true for older snapshots collected before this field existed, since every committer seen in this project's history so far has been a real login).
Simple version -- just links every login to https://github.com/<login>, no schema change. If a login turns out not to be a real username (rare edge case: an unlinked commit falls back to a raw git author name), the link 404s; not worth a data-model change to guard against that now.
mike-wendt
commented
Sep 5, 2026
mike-wendt
left a comment
mike-wendt
left a comment
Contributor
Author
There was a problem hiding this comment.
Self-reviewed and approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Links each name in the "Top committers" table to
https://github.com/<login>.Kept simple per feedback -- just adds the
href, no data model changes.top_committers[].logincan technically fall back to a raw git author name instead of a real GitHub username in the rare case a commit isn't linked to a GitHub account, which would make the link 404. Not guarding against that now; revisit only if it turns out to matter in practice.Test plan
uv run scripts/build_site.pyexits cleanly{text, href}cell patternshared.js'sbuildCellItemalready renders correctly elsewhere (topPaths) -- no new client-side logicVerify pipeline / verifypasses on this PR🤖 Generated with Claude Code