feat: print version and exit on --version#463
Merged
Conversation
Running ccstatusline --version launched the TUI instead of reporting the version. Handle the flag at the top of main() before mode detection: print getPackageVersion() and exit. Closes sirmalloc#461.
Owner
|
Thanks, it'll go out in the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ccstatusline --versioncurrently launches the interactive TUI instead of reporting the version. The entry point only branches on--hookand then TTY-vs-piped mode, so an unrecognized flag falls through to the TUI. This adds a--versioncheck at the top ofmain()that prints the version and exits, which is the expected behavior for a CLI/TUI.Closes #461.
Approach
A single guard before mode detection in
src/ccstatusline.ts, reusing the existinggetPackageVersion()helper fromsrc/utils/terminal.ts:getPackageVersion()returns the build-substituted version and falls back to readingpackage.json, so--versionis correct both from the published build and when run from source.--config/--hookargument handling.Test plan
bun run lintpasses (tsc + eslint,--max-warnings=0).--versionprints the version and exits 0:bun run src/ccstatusline.ts --version->2.2.22node dist/ccstatusline.js --version->2.2.22