Tests for Parser.SpecialChar() and extension options#168
Open
kevin-lee wants to merge 3 commits intosirthias:masterfrom
Open
Tests for Parser.SpecialChar() and extension options#168kevin-lee wants to merge 3 commits intosirthias:masterfrom
kevin-lee wants to merge 3 commits intosirthias:masterfrom
Conversation
…etect bugs like sirthias#159 and sirthias#161).
…etect bugs like sirthias#159 and sirthias#161).
Contributor
|
Instead of those formOptions and collectPairs, I think combinations could be used to generate extension option pairs. |
Author
|
@Deraen You're right! 👍 I enjoyed it too much I guess. I'll fix it. |
… instead of recursive functions as suggested by @Deraen.
Owner
|
If I merge this PR into the current master these new tests fail. |
Author
|
@sirthias Oh! OK, that's good! I will. 😃 Thank you! |
sirthias
force-pushed
the
master
branch
5 times, most recently
from
5729862 to
19ca3d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request contains tests for Parser.SpecialChar() and extension options (It can detect bugs like #159 and #161).