text_formatter: add support for GoString#1087
Open
chris3torek wants to merge 1 commit into
Open
Conversation
Allow logging fields with their GoString result. When using GoString, never add extra quotes, regardless of the ForceQuote setting: the GoString format should take care of this. Note that if some field does not implement the GoString interface, we fall through to the remaining logic, which obeys ForceQuote as usual.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: I have not created an issue for this and don't really feel all that strongly one way or another about it. I was experimenting with some logging options and it seemed to me that logging fields in their GoString output format was clearer when they weren't quoted.
Without this, given a type like this (the Stringer and GoStringer are the same mainly for illustration):
produces (I've trimmed a bit of interior whitespace for this PR text):
With GoString enabled we get:
which just seems prettier. A well-formed GoString should produce unambiguously encoded results, so it won't need quotes.
Commit message text follows...
Allow logging fields with their GoString result. When using
GoString, never add extra quotes, regardless of the ForceQuote
setting: the GoString format should take care of this.
Note that if some field does not implement the GoString
interface, we fall through to the remaining logic, which
obeys ForceQuote as usual.