Properly close the writer and wait for all writes to finish - #1092
Open
adieu wants to merge 1 commit into
Open
Conversation
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I use
logger.Writer()asio.Writerfor the output of my program and found that sometimes when the program exit too fast, some output wouldn't be displayed even if I close the writer before exit.After reading
writer.goI found that when we callwriter.Close()we don't wait forentry.writerScanner()which runs in another goroutine to finish.This commit adds
WriterLevelWithClosewhich returns acloseFuncto properly close the writer and reader.Eventually we might have to modify
WriterandWriterLevelto return thecloseFunctoo which is not backward compatible or we might wrap the writer and return anio.WriteCloserinstead.