Support error array in field when using json formatter - #1413
Open
same-id wants to merge 1 commit into
Open
Conversation
Author
|
Bump, I think this can count as a bug fix |
thaJeztah
reviewed
Feb 27, 2026
Comment on lines
+79
to
+80
| case []error: | ||
| data[k] = errorsArrayToStrings(v) |
Collaborator
There was a problem hiding this comment.
Slightly thinking out loud here; now that go stdlib provides native support for "multi-errors" through errors.Join, I wonder if this is something that would be better fixed in the code using logrus.
i.e.; instead of WithField("errors", []error{...}), to use WithError(errors.Join(errs....)) (or similar)
Collaborator
There was a problem hiding this comment.
The tricky bit is that logrus will (probably) never be able to fully cover all scenarios; if such a []error (or a regular error) would be part of a struct that's set as field; it would probably still produce a non-string output for the error(s).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to:
#137