fix(hooks): fire remaining hooks after a Hook.Fire error - #1574
Open
VedantMadane wants to merge 1 commit into
Open
fix(hooks): fire remaining hooks after a Hook.Fire error#1574VedantMadane wants to merge 1 commit into
VedantMadane wants to merge 1 commit into
Conversation
VedantMadane
force-pushed
the
fix-issue-408
branch
from
August 22, 2026 13:21
f37b282 to
00c6dd2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #408.
LevelHooks.Firepreviously returned on the first hook error, so later hooks never ran (contradicting the doc: fire all hooks for the level).Now every hook for the level is invoked; errors are combined with
errors.Join.As suggested by the maintainer, this avoids importing a multierror package.
Test plan
TestHookFireContinuesAfterErrorTestHookFireOrderstill passes