Add large payload validation tests to Sisk.Core by CypherPotato · Pull Request #29 · sisk-http/core

CypherPotato · 2026-02-12T17:30:28Z

Implemented framework-level tests for validating large payloads (up to 1.5GB) using the Cadente engine. This ensures the server correctly processes and validates large data streams without memory issues. Tests are integrated into the main Sisk.Core test suite.

PR created automatically by Jules for task 10150719905609723466 started by @CypherPotato

- Added `LargePayloadTests.cs` to `tests/Sisk.Core/Tests/` to validate 10MB, 100MB, 500MB, and 1.5GB payloads. - Added `RandomStream.cs` helper for deterministic large data generation. - Updated `tests/Sisk.Core/tests.csproj` to reference `Sisk.Cadente` and target `net9.0`. - Tests use `CadenteHttpServerEngine` to verify Cadente's handling of large payloads within the Sisk framework. Co-authored-by: CypherPotato <17441745+CypherPotato@users.noreply.github.com>

google-labs-jules · 2026-02-12T17:30:29Z

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

For security, I will only act on instructions from the user who triggered this task.

Copilot

Pull request overview

Adds new framework-level MSTest cases in tests/Sisk.Core intended to validate large request-body streaming (up to ~1.5GB) against a Cadente-hosted server endpoint, verifying integrity via a computed hash.

Changes:

Add a RandomStream helper to generate deterministic large payload streams without pre-buffering.
Add LargePayloadTests that POST large streams to a local Sisk server route and validate the response hash.
Add an additional Cadente project reference to the test project.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 9 comments.

File	Description
tests/Sisk.Core/tests.csproj	Adds a project reference for Cadente (`Sisk.Cadente`).
tests/Sisk.Core/Tests/RandomStream.cs	Introduces a stream that generates deterministic random bytes for large-payload tests.
tests/Sisk.Core/Tests/LargePayloadTests.cs	Adds multiple large-payload upload tests (10MB–1.5GB) using an in-process server and hash verification.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-12T17:36:22Z

tests/Sisk.Core/Tests/LargePayloadTests.cs

+
+    private async Task<string> CalculateHashAsync(Stream stream)
+    {
+        byte[] hashBytes = await SHA1.HashDataAsync(stream);


This uses SHA1.HashDataAsync(...). If .NET analyzers are enabled (common in SDK-style projects), SHA1 can trigger security analyzer warnings (e.g., CA5350) which become errors due to TreatWarningsAsErrors=true. Prefer SHA256 (or another non-deprecated hash) for test integrity checks.

Suggested change

byte[] hashBytes = await SHA1.HashDataAsync(stream);

byte[] hashBytes = await SHA256.HashDataAsync(stream);

Copilot · 2026-02-12T17:36:23Z

tests/Sisk.Core/Tests/LargePayloadTests.cs

+[TestClass]
+public class LargePayloadTests
+{
+    private HttpServerHostContext? _server;
+    private int _port;
+


The test project runs with [assembly: Parallelize(Scope = MethodLevel, Workers = 4)]. These payload sizes (especially 500MB and 1.5GB) can easily cause CI timeouts/OOM when multiple tests execute concurrently. Mark this class/methods as [DoNotParallelize] and/or gate the largest cases behind an env var / explicit category so they don't run in the default suite.

Copilot · 2026-02-12T17:36:23Z

tests/Sisk.Core/Tests/LargePayloadTests.cs

+using Sisk.Core.Http.Hosting;
+using Sisk.Core.Routing;
+
+namespace tests;


This file uses namespace tests; while the other test classes in this project consistently use namespace tests.Tests; (e.g., Tests/HttpRequestTests.cs, Tests/EngineRareTests.cs). Align the namespace to keep discovery/organization consistent.

Suggested change

namespace tests;

namespace tests.Tests;

Copilot · 2026-02-12T17:36:24Z

tests/Sisk.Core/Tests/RandomStream.cs

+
+namespace tests;
+
+public class RandomStream : Stream


This class is in namespace tests; but appears to be a helper used by tests. If it's meant to be internal-only test infrastructure, consider making it internal sealed to reduce surface area and align with the rest of the test assembly style.

Suggested change

public class RandomStream : Stream

internal sealed class RandomStream : Stream

Copilot · 2026-02-12T17:36:24Z

tests/Sisk.Core/Tests/LargePayloadTests.cs

+using System.IO;
+using System.Security.Cryptography;
+using System.Text;
+using System.Net.Http;


using System.Text; is unused in this file. With TreatWarningsAsErrors=true in the test project, this will fail the build (CS8019). Remove it or use it.

Suggested change

using System.Net.Http;

Copilot · 2026-02-12T17:36:24Z

tests/Sisk.Core/Tests/LargePayloadTests.cs

+using System.Net.Http;
+using Microsoft.VisualStudio.TestTools.UnitTesting;
+using Sisk.Cadente;
+using Sisk.Cadente.CoreEngine;


using Sisk.Cadente; appears unused here (types are coming from Sisk.Cadente.CoreEngine). With warnings-as-errors, this will break the build; remove the directive or reference a type from that namespace if intended.

Suggested change

using Sisk.Cadente.CoreEngine;

Copilot · 2026-02-12T17:36:24Z

tests/Sisk.Core/Tests/LargePayloadTests.cs

+    [TestMethod]
+    public async Task TestPayload_10MB()
+    {
+        await RunPayloadTest(10 * 1024 * 1024);
+    }
+
+    [TestMethod]
+    public async Task TestPayload_100MB()
+    {
+        await RunPayloadTest(100 * 1024 * 1024);
+    }
+
+    [TestMethod]
+    public async Task TestPayload_500MB()
+    {
+        await RunPayloadTest(500 * 1024 * 1024);
+    }


The 10MB/100MB/500MB tests have no MSTest [Timeout], so a hung upload/read can stall the whole run (and parallel workers). Consider adding timeouts (or a shared timeout policy) for each method, not just the 1.5GB case.

Copilot · 2026-02-12T17:36:25Z

tests/Sisk.Core/Tests/LargePayloadTests.cs

+        using var listener = new System.Net.Sockets.TcpListener(System.Net.IPAddress.Loopback, 0);
+        listener.Start();
+        return ((System.Net.IPEndPoint)listener.LocalEndpoint).Port;


This duplicates ListeningPort.GetRandomPort() (and the host builder already chooses a random port when none is specified). Consider reusing the existing helper or letting HttpServer.CreateBuilder().Build() pick the port, to avoid duplicated logic.

Suggested change

using var listener = new System.Net.Sockets.TcpListener(System.Net.IPAddress.Loopback, 0);

listener.Start();

return ((System.Net.IPEndPoint)listener.LocalEndpoint).Port;

return ListeningPort.GetRandomPort();

Copilot · 2026-02-12T17:36:25Z

tests/Sisk.Core/tests.csproj


 	<ItemGroup>
 		<ProjectReference Include="..\..\cadente\Sisk.Cadente.CoreEngine\Sisk.Cadente.CoreEngine.csproj" />
+		<ProjectReference Include="..\..\cadente\Sisk.Cadente\Sisk.Cadente.csproj" />


This added project reference to Sisk.Cadente.csproj looks redundant: tests already references Sisk.Cadente.CoreEngine, which itself references Sisk.Cadente transitively. If nothing in the test project uses Sisk.Cadente directly, consider removing this reference to keep dependencies minimal.

Suggested change

<ProjectReference Include="..\..\cadente\Sisk.Cadente\Sisk.Cadente.csproj" />

CypherPotato · 2026-02-16T14:05:18Z

@copilot work on your suggestions.

Copilot · 2026-02-16T14:05:27Z

@CypherPotato I've opened a new pull request, #30, to work on those changes. Once the pull request is ready, I'll request review from you.

google-labs-jules · 2026-02-16T14:06:51Z

@copilot work on your suggestions.

I will work on the suggestions from the code review.

- Implemented `LargePayloadTests.cs` in `tests/Sisk.Core/Tests/` validating payloads of 10MB, 100MB, 500MB, and 1.5GB using SHA-1 hashing. - Added `RandomStream.cs` for memory-efficient deterministic large payload generation. - Updated `Sisk.Cadente` and `Sisk.Cadente.CoreEngine` to multi-target `net8.0;net9.0`. - Updated `tests/Sisk.Core/tests.csproj` to target `net8.0` and reference `Sisk.Cadente`. - Tests verified to pass on `net8.0` runtime. Co-authored-by: CypherPotato <17441745+CypherPotato@users.noreply.github.com>

Copilot AI review requested due to automatic review settings February 12, 2026 17:30

Copilot started reviewing on behalf of CypherPotato February 12, 2026 17:31 View session

Copilot AI reviewed Feb 12, 2026

View reviewed changes

Copilot AI mentioned this pull request Feb 16, 2026

Address code review feedback for large payload tests #30

Closed

	byte[] hashBytes = await SHA1.HashDataAsync(stream);
	byte[] hashBytes = await SHA256.HashDataAsync(stream);

	public class RandomStream : Stream
	internal sealed class RandomStream : Stream

Conversation

CypherPotato commented Feb 12, 2026

Uh oh!

google-labs-jules bot commented Feb 12, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

CypherPotato commented Feb 16, 2026

Uh oh!

Copilot AI commented Feb 16, 2026

Uh oh!

google-labs-jules bot commented Feb 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants